From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752727AbbAYXz7 (ORCPT ); Sun, 25 Jan 2015 18:55:59 -0500 Received: from helcar.apana.org.au ([209.40.204.226]:60571 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbbAYXz5 (ORCPT ); Sun, 25 Jan 2015 18:55:57 -0500 Date: Mon, 26 Jan 2015 10:55:50 +1100 From: Herbert Xu To: Stephan Mueller Cc: Daniel Borkmann , "'Quentin Gouchet'" , "'LKML'" , linux-crypto@vger.kernel.org, linux-api@vger.kernel.org, Neil Horman Subject: Re: [PATCH v11 1/2] crypto: AF_ALG: add AEAD support Message-ID: <20150125235550.GB18212@gondor.apana.org.au> References: <1923793.K38mGRD6eo@tachyon.chronox.de> <6238416.vGUni1CI4i@tachyon.chronox.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6238416.vGUni1CI4i@tachyon.chronox.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 21, 2015 at 02:19:17AM +0100, Stephan Mueller wrote: > > + /* use the existing memory in an allocated page */ > + if (ctx->merge) { > + sg = sgl->sg + sgl->cur - 1; > + len = min_t(unsigned long, len, > + PAGE_SIZE - sg->offset - sg->length); > + err = memcpy_from_msg(page_address(sg_page(sg)) + > + sg->offset + sg->length, > + msg, len); > + if (err) > + goto unlock; > + > + sg->length += len; > + ctx->merge = (sg->offset + sg->length) & > + (PAGE_SIZE - 1); > + > + ctx->used += len; > + copied += len; > + size -= len; Need to add a continue here to recheck size != 0. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt