From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753252AbbAZElX (ORCPT ); Sun, 25 Jan 2015 23:41:23 -0500 Received: from helcar.apana.org.au ([209.40.204.226]:34762 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751810AbbAZElV (ORCPT ); Sun, 25 Jan 2015 23:41:21 -0500 Date: Mon, 26 Jan 2015 15:41:14 +1100 From: Herbert Xu To: Stephan Mueller Cc: Daniel Borkmann , "'Quentin Gouchet'" , "'LKML'" , linux-crypto@vger.kernel.org, linux-api@vger.kernel.org, Neil Horman Subject: Re: [PATCH v11 1/2] crypto: AF_ALG: add AEAD support Message-ID: <20150126044114.GA21056@gondor.apana.org.au> References: <1923793.K38mGRD6eo@tachyon.chronox.de> <1526868.qaVuSjCOn7@tachyon.chronox.de> <20150126043218.GA20911@gondor.apana.org.au> <1793732.EQDAUxrRn5@tachyon.chronox.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1793732.EQDAUxrRn5@tachyon.chronox.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 26, 2015 at 05:39:27AM +0100, Stephan Mueller wrote: > > But does it really matter if we consider size == 0 or != at this point? In > case size == 0, the len calculation before the inner while loop will return 0. Of course it matters because you may die due to the aead_writable check. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt