LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH 1/3] swiotlb: Warn on allocation failure in swiotlb_alloc_coherent
Date: Mon, 26 Jan 2015 12:49:45 +0100	[thread overview]
Message-ID: <20150126114945.GD30345@8bytes.org> (raw)
In-Reply-To: <20150123170425.GI22635@pd.tnic>

On Fri, Jan 23, 2015 at 06:04:25PM +0100, Borislav Petkov wrote:
> On Tue, Jan 06, 2015 at 03:51:12PM +0100, Joerg Roedel wrote:
> > +
> > +err_warn:
> > +	pr_warn("swiotlb: coherent allocation failed for device %s size=%zu\n",
> > +		dev_name(hwdev), size);
> > +	dump_stack();
> 
> Are we really sure we want to be that noisy about it? What happens if
> that fails, we can't do DMA anymore or should we free some precious DMA
> memory, as a compromise?

Hmm, I don't think there is a way to request drivers to free DMA memory.
What this patch does is to keep the same noisiness as before, just not
from the page allocator but from the very end of the DMA allocation
process, when everything failed.
We can of course discuss whether this is too noisy and put some kind of
ratelimit around.


	Joerg


  reply	other threads:[~2015-01-26 11:49 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06 14:51 [PATCH 0/3 v2] Fix kdump failures with crashkernel=high Joerg Roedel
2015-01-06 14:51 ` [PATCH 1/3] swiotlb: Warn on allocation failure in swiotlb_alloc_coherent Joerg Roedel
2015-01-23 17:04   ` Borislav Petkov
2015-01-26 11:49     ` Joerg Roedel [this message]
2015-01-06 14:51 ` [PATCH 2/3] x86, swiotlb: Try coherent allocations with __GFP_NOWARN Joerg Roedel
2015-01-23 17:03   ` Borislav Petkov
2015-01-26  3:22     ` Baoquan He
2015-01-26 11:54       ` Joerg Roedel
2015-01-06 14:51 ` [PATCH 3/3] x86, crash: Allocate enough low-mem when crashkernel=high Joerg Roedel
2015-01-23  8:44   ` Baoquan He
2015-01-26 12:07     ` Joerg Roedel
2015-02-01  8:41       ` Baoquan He
2015-02-04 14:10         ` Joerg Roedel
2015-02-09 12:20           ` Joerg Roedel
2015-02-13 15:34             ` Baoquan He
2015-02-13 22:28               ` Joerg Roedel
2015-02-14 11:44                 ` Baoquan He
2015-01-23 17:02   ` Borislav Petkov
2015-01-26 12:11     ` Joerg Roedel
2015-01-26 12:20       ` Borislav Petkov
2015-01-26 12:40         ` Joerg Roedel
2015-01-26 12:45           ` Borislav Petkov
2015-01-14 13:35 ` [PATCH 0/3 v2] Fix kdump failures with crashkernel=high Joerg Roedel
2015-01-19 19:26 ` Borislav Petkov
2015-02-14 10:58 ` Baoquan He
2015-02-14 16:11   ` Joerg Roedel
2015-06-02  8:54     ` Baoquan He
2015-06-02  9:08       ` Joerg Roedel
  -- strict thread matches above, loose matches on Subject: below --
2015-06-05 10:29 [PATCH 0/3 v3] " Joerg Roedel
2015-06-05 10:30 ` [PATCH 1/3] swiotlb: Warn on allocation failure in swiotlb_alloc_coherent Joerg Roedel
2014-11-28 11:29 [PATCH 0/3] Fix kdump failures with crashkernel=high Joerg Roedel
2014-11-28 11:29 ` [PATCH 1/3] swiotlb: Warn on allocation failure in swiotlb_alloc_coherent Joerg Roedel
2014-12-01 20:28   ` Konrad Rzeszutek Wilk
2014-12-02 14:41     ` Joerg Roedel
2014-12-02 18:46       ` Konrad Rzeszutek Wilk
2014-12-03 10:26         ` Joerg Roedel
2014-12-11 19:08           ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150126114945.GD30345@8bytes.org \
    --to=joro@8bytes.org \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jroedel@suse.de \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).