LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
@ 2015-01-26 12:52 Heba Aamer
  2015-01-27 10:17 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: Heba Aamer @ 2015-01-26 12:52 UTC (permalink / raw)
  To: devel
  Cc: Larry.Finger, florian.c.schilhabel, gregkh, tapaswenipathak,
	thomas, sudipm.mukherjee, rickard_strandqvist, linux-kernel

This patch fixes the following checkpatch.pl warning:
fix Prefer [subsystem eg: netdev]_info([subsystem]dev,
... then dev_info(dev, ... then pr_info(...  to
printk(KERN_INFO ...

Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
---
v2: changed netdev_info to pr_info

 drivers/staging/rtl8712/usb_intf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
index 7d0d171..15f0d42 100644
--- a/drivers/staging/rtl8712/usb_intf.c
+++ b/drivers/staging/rtl8712/usb_intf.c
@@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
 	struct net_device *pnetdev;
 	struct usb_device *udev;
 
-	printk(KERN_INFO "r8712u: Staging version\n");
+	pr_info("r8712u: Staging version\n");
 	/* In this probe function, O.S. will provide the usb interface pointer
 	 * to driver. We have to increase the reference count of the usb device
 	 * structure by using the usb_get_dev function.
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
  2015-01-26 12:52 [PATCH v2] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO Heba Aamer
@ 2015-01-27 10:17 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2015-01-27 10:17 UTC (permalink / raw)
  To: Heba Aamer
  Cc: devel, florian.c.schilhabel, thomas, tapaswenipathak, gregkh,
	rickard_strandqvist, linux-kernel, sudipm.mukherjee,
	Larry.Finger


The subject line is too long.

> -	printk(KERN_INFO "r8712u: Staging version\n");
> +	pr_info("r8712u: Staging version\n");

This is a dumb thing to print.  Just delete this line.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-27 10:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-26 12:52 [PATCH v2] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO Heba Aamer
2015-01-27 10:17 ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).