LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] memcg: fix static checker warning
@ 2015-01-26 12:44 Kirill A. Shutemov
  2015-01-26 13:37 ` Michal Hocko
  0 siblings, 1 reply; 2+ messages in thread
From: Kirill A. Shutemov @ 2015-01-26 12:44 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-mm, linux-kernel, Kirill A. Shutemov

The patch "mm: remove rest usage of VM_NONLINEAR and pte_file()" from
Jan 17, 2015, leads to the following static checker warning:

        mm/memcontrol.c:4794 mc_handle_file_pte()
        warn: passing uninitialized 'pgoff'

After the patch, the only case when mc_handle_file_pte() called is
pte_none(ptent). The 'if' check is redundant and lead to the warning.
Let's drop it.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 mm/memcontrol.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index cd42f14d138a..a6140c0764f4 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4792,8 +4792,7 @@ static struct page *mc_handle_file_pte(struct vm_area_struct *vma,
 		return NULL;
 
 	mapping = vma->vm_file->f_mapping;
-	if (pte_none(ptent))
-		pgoff = linear_page_index(vma, addr);
+	pgoff = linear_page_index(vma, addr);
 
 	/* page is moved even if it's not RSS of this task(page-faulted). */
 #ifdef CONFIG_SWAP
-- 
2.1.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] memcg: fix static checker warning
  2015-01-26 12:44 [PATCH] memcg: fix static checker warning Kirill A. Shutemov
@ 2015-01-26 13:37 ` Michal Hocko
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Hocko @ 2015-01-26 13:37 UTC (permalink / raw)
  To: Kirill A. Shutemov; +Cc: Andrew Morton, linux-mm, linux-kernel

On Mon 26-01-15 14:44:08, Kirill A. Shutemov wrote:
> The patch "mm: remove rest usage of VM_NONLINEAR and pte_file()" from
> Jan 17, 2015, leads to the following static checker warning:
> 
>         mm/memcontrol.c:4794 mc_handle_file_pte()
>         warn: passing uninitialized 'pgoff'
> 
> After the patch, the only case when mc_handle_file_pte() called is
> pte_none(ptent). The 'if' check is redundant and lead to the warning.
> Let's drop it.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Michal Hocko <mhocko@suse.cz>

> ---
>  mm/memcontrol.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index cd42f14d138a..a6140c0764f4 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -4792,8 +4792,7 @@ static struct page *mc_handle_file_pte(struct vm_area_struct *vma,
>  		return NULL;
>  
>  	mapping = vma->vm_file->f_mapping;
> -	if (pte_none(ptent))
> -		pgoff = linear_page_index(vma, addr);
> +	pgoff = linear_page_index(vma, addr);
>  
>  	/* page is moved even if it's not RSS of this task(page-faulted). */
>  #ifdef CONFIG_SWAP
> -- 
> 2.1.4
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
Michal Hocko
SUSE Labs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-26 13:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-26 12:44 [PATCH] memcg: fix static checker warning Kirill A. Shutemov
2015-01-26 13:37 ` Michal Hocko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).