LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jiri Olsa <jolsa@kernel.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 2/5] tools lib api fs: Add tracefs mount helper functions
Date: Mon, 26 Jan 2015 12:44:12 -0200 [thread overview]
Message-ID: <20150126144412.GA2406@redhat.com> (raw)
In-Reply-To: <20150126143148.GA2122@krava.brq.redhat.com>
Em Mon, Jan 26, 2015 at 03:31:48PM +0100, Jiri Olsa escreveu:
> On Mon, Jan 26, 2015 at 09:26:21AM -0500, Steven Rostedt wrote:
> > On Mon, 26 Jan 2015 10:02:55 +0100
> > Jiri Olsa <jolsa@redhat.com> wrote:
> >
> > > > Note, WTF is perf checking the magic number for debugfs?? If events
> > > > move, even if its at the same path, this will break perf!
> > >
> > > good question.. it's there since 2009:
> > > f6bdafef2ab9 perf_counter: Add tracepoint support to perf list, perf stat
> > >
> > > I guess we didn't want anyone to trick us with fake tracepoints ;-)
> >
> > But that would be a feature not a bug. I could imagine admins doing
> > this for some work around.
> >
> > But can we nuke that check? I don't think it's very useful.
>
> I'd be ok with that
Yeah, that check is a nuisance, should be removed as it takes away
flexibility...
- Arnaldo
next prev parent reply other threads:[~2015-01-26 14:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-24 18:13 [PATCH 0/5] perf: Have perf become tracefs aware Steven Rostedt
2015-01-24 18:13 ` [PATCH 1/5] tools lib fs: Add helper to find mounted file systems Steven Rostedt
2015-01-25 16:41 ` Jiri Olsa
2015-01-25 19:20 ` Steven Rostedt
2015-01-24 18:13 ` [PATCH 2/5] tools lib api fs: Add tracefs mount helper functions Steven Rostedt
2015-01-25 16:45 ` Jiri Olsa
2015-01-25 19:22 ` Steven Rostedt
2015-01-25 16:51 ` Jiri Olsa
2015-01-25 19:24 ` Steven Rostedt
2015-01-25 16:56 ` Jiri Olsa
2015-01-25 19:26 ` Steven Rostedt
2015-01-26 9:02 ` Jiri Olsa
2015-01-26 14:26 ` Steven Rostedt
2015-01-26 14:31 ` Jiri Olsa
2015-01-26 14:44 ` Arnaldo Carvalho de Melo [this message]
2015-01-24 18:13 ` [PATCH 3/5] tools lib api fs: Add DEBUGFS_DEFAULT_PATH macro Steven Rostedt
2015-01-24 18:13 ` [PATCH 4/5] tools lib api fs: Add {tracefs,debugfs}_configured() functions Steven Rostedt
2015-01-25 17:02 ` Jiri Olsa
2015-01-25 19:27 ` Steven Rostedt
2015-01-24 18:13 ` [PATCH 5/5] perf: Make perf aware of tracefs Steven Rostedt
2015-01-25 13:50 ` Namhyung Kim
2015-01-25 19:19 ` Steven Rostedt
2015-01-25 17:34 ` Jiri Olsa
2015-01-25 19:31 ` Steven Rostedt
2015-01-26 8:57 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126144412.GA2406@redhat.com \
--to=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--subject='Re: [PATCH 2/5] tools lib api fs: Add tracefs mount helper functions' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).