LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Benoit Parrot <bparrot@ti.com>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>,
	LAK <linux-arm-kernel@lists.infradead.org>,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Darren Etheridge <detheridge@ti.com>, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH v2] ARM: AM43xx: hwmod: add VPFE hwmod entries
Date: Mon, 26 Jan 2015 09:50:32 -0600	[thread overview]
Message-ID: <20150126155032.GD2570@ti.com> (raw)
In-Reply-To: <CA+V-a8urS2C20FDcfsGa+Gg+7wmbbQQw3U7BfXf6GBKoBGMc9w@mail.gmail.com>

Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote on Mon [2015-Jan-26 08:13:01 +0000]:
> Hi Paul,
> 
> Thanks for the review.
> 
> On Mon, Jan 26, 2015 at 2:15 AM, Paul Walmsley <paul@pwsan.com> wrote:
> > Hi
> >
> > On Sun, 25 Jan 2015, Lad, Prabhakar wrote:
> >
> >> From: Benoit Parrot <bparrot@ti.com>
> >>
> >> this patch adds VPFE HWMOD data for AM43xx.
> >>
> >> Signed-off-by: Benoit Parrot <bparrot@ti.com>
> >> Signed-off-by: Darren Etheridge <detheridge@ti.com>
> >> Signed-off-by: Felipe Balbi <balbi@ti.com>
> >> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> >> ---
> >>  Hi Paul,
> >>
> >>  You were right, the hardware team has confirmed that, the VPFE master port is
> >>  connected to L3 and the VPFE slave port is connected to L4. The L3 port cannot
> >>  serve as a register target because it is initiator only.
> >
> > OK makes sense to me.,
> >
> >>
> >>  I have created links referring to dss l3/l4 hwmod and tested it, lemme know
> >>  if I have missed something.
> >
> > A few minor comments below
> >
> >>
> [Snip]
> >>  /* Interfaces */
> >>  static struct omap_hwmod_ocp_if am43xx_l3_main__l4_hs = {
> >>       .master         = &am33xx_l3_main_hwmod,
> >> @@ -788,6 +826,36 @@ static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_rfbi = {
> >>       .user           = OCP_USER_MPU | OCP_USER_SDMA,
> >>  };
> >>
> >> +static struct omap_hwmod_ocp_if am43xx_l3__vpfe0 = {
> >> +     .master         = &am43xx_vpfe0_hwmod,
> >> +     .slave          = &am33xx_l3_main_hwmod,
> >> +     .clk            = "l3_gclk",
> >> +     .flags          = OCPIF_SWSUP_IDLE,
> >
> > OCPIF_SWSUP_IDLE probably isn't needed here.  Could you please try without
> > it?
> >
> >> +     .user           = OCP_USER_MPU | OCP_USER_SDMA,
> >> +};
> >> +
> >> +static struct omap_hwmod_ocp_if am43xx_l3__vpfe1 = {
> >> +     .master         = &am43xx_vpfe1_hwmod,
> >> +     .slave          = &am33xx_l3_main_hwmod,
> >> +     .clk            = "l3_gclk",
> >> +     .flags          = OCPIF_SWSUP_IDLE,
> >
> > Same point as the above.
> >
> Dropped and tested works! posting a v3.

When you tested it without the OCPIF_SWSUP_IDLE, did you go trhough a complete suspend/resume cycle?
This flag was added early on because otherwise the susbsytem would not go idle without it...

Can you post the console output during a suspend/resume cycle?

Benoit

> 
> Cheers,
> --Prabhakar Lad

  reply	other threads:[~2015-01-26 15:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-25 20:31 Lad, Prabhakar
2015-01-26  2:15 ` Paul Walmsley
2015-01-26  8:13   ` Lad, Prabhakar
2015-01-26 15:50     ` Benoit Parrot [this message]
2015-01-26 15:56       ` Lad, Prabhakar
2015-01-26 18:47         ` Paul Walmsley
2015-01-28 19:30           ` Benoit Parrot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150126155032.GD2570@ti.com \
    --to=bparrot@ti.com \
    --cc=balbi@ti.com \
    --cc=detheridge@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=tony@atomide.com \
    --subject='Re: [PATCH v2] ARM: AM43xx: hwmod: add VPFE hwmod entries' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).