LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes
@ 2015-01-22 20:38 Marek Belisko
  2015-01-22 20:38 ` [PATCH 01/13] ARM: dts: omap3-gta04: Fix backup-battery charging in devicetree file Marek Belisko
                   ` (13 more replies)
  0 siblings, 14 replies; 19+ messages in thread
From: Marek Belisko @ 2015-01-22 20:38 UTC (permalink / raw)
  To: bcousson, tony
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, hns,
	neilb, Marek Belisko

This series contains fixes for gta04 devicetree. I collected patches
from H. Nikolaus Schaller + NeilBrown and myself. Patches contains mostly fixes
+ adding new nodes and comments. All changes tested on gta04a4 board.

H. Nikolaus Schaller (5):
  ARM: dts: omap3-gta04: Fix backup-battery charging in devicetree file.
  ARM: dts: omap3-gta04: Fix audio node malformatting
  ARM: dts: omap3-gta04: Enable mcbps2 necessary for audio
  ARM: dts: omap3-gta04: Enable twl audio vibra support
  ARM: dts: omap3-gta04: Enable power-off using twl4030

Marek Belisko (2):
  ARM: dts: omap3-gta04: Fix a GPIO line for bma180 node
  ARM: dts: omap3-gta04: Add ramp value for twl4030 audio

NeilBrown (6):
  ARM: dts: omap3-gta04: add comments about gpios
  ARM: dts: omap3-gta04: enable power-off for wifi card.
  ARM: dts: omap3-gta04: add gyroscope
  ARM: dts: omap3-gta04: only power DSS when necessary.
  ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled"
  ARM: dts: omap3-gta04: Disable keypad

 arch/arm/boot/dts/omap3-gta04.dtsi | 54 +++++++++++++++++++++++++++-----------
 1 file changed, 39 insertions(+), 15 deletions(-)

-- 
1.9.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 01/13] ARM: dts: omap3-gta04: Fix backup-battery charging in devicetree file.
  2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
@ 2015-01-22 20:38 ` Marek Belisko
  2015-01-22 20:38 ` [PATCH 02/13] ARM: dts: omap3-gta04: Fix audio node malformatting Marek Belisko
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 19+ messages in thread
From: Marek Belisko @ 2015-01-22 20:38 UTC (permalink / raw)
  To: bcousson, tony
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, hns,
	neilb

From: "H. Nikolaus Schaller" <hns@goldelico.com>

Fix attribute names.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 655d6e9..fa39232 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -342,8 +342,8 @@
 };
 
 &charger {
-	bb_uvolt = <3200000>;
-	bb_uamp = <150>;
+	ti,bb-uvolt = <3200000>;
+	ti,bb-uamp = <150>;
 };
 
 /* spare */
-- 
1.9.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 02/13] ARM: dts: omap3-gta04: Fix audio node malformatting
  2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
  2015-01-22 20:38 ` [PATCH 01/13] ARM: dts: omap3-gta04: Fix backup-battery charging in devicetree file Marek Belisko
@ 2015-01-22 20:38 ` Marek Belisko
  2015-01-22 20:38 ` [PATCH 03/13] ARM: dts: omap3-gta04: Enable mcbps2 necessary for audio Marek Belisko
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 19+ messages in thread
From: Marek Belisko @ 2015-01-22 20:38 UTC (permalink / raw)
  To: bcousson, tony
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, hns,
	neilb

From: "H. Nikolaus Schaller" <hns@goldelico.com>

Audio should be child of twl node.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index fa39232..c78380e 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -202,11 +202,11 @@
 		reg = <0x48>;
 		interrupts = <7>; /* SYS_NIRQ cascaded to intc */
 		interrupt-parent = <&intc>;
-	};
 
-	twl_audio: audio {
-		compatible = "ti,twl4030-audio";
-		codec {
+		twl_audio: audio {
+			compatible = "ti,twl4030-audio";
+			codec {
+			};
 		};
 	};
 };
-- 
1.9.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 03/13] ARM: dts: omap3-gta04: Enable mcbps2 necessary for audio
  2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
  2015-01-22 20:38 ` [PATCH 01/13] ARM: dts: omap3-gta04: Fix backup-battery charging in devicetree file Marek Belisko
  2015-01-22 20:38 ` [PATCH 02/13] ARM: dts: omap3-gta04: Fix audio node malformatting Marek Belisko
@ 2015-01-22 20:38 ` Marek Belisko
  2015-01-22 20:38 ` [PATCH 04/13] ARM: dts: omap3-gta04: Enable twl audio vibra support Marek Belisko
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 19+ messages in thread
From: Marek Belisko @ 2015-01-22 20:38 UTC (permalink / raw)
  To: bcousson, tony
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, hns,
	neilb

From: "H. Nikolaus Schaller" <hns@goldelico.com>

mcbsp2 is used in gta04 soundcard config and by default
is disabled so enable it for gta04.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index c78380e..7272591 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -449,3 +449,7 @@
 		};
 	};
 };
+
+&mcbsp2 {
+	status = "okay";
+};
-- 
1.9.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 04/13] ARM: dts: omap3-gta04: Enable twl audio vibra support
  2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
                   ` (2 preceding siblings ...)
  2015-01-22 20:38 ` [PATCH 03/13] ARM: dts: omap3-gta04: Enable mcbps2 necessary for audio Marek Belisko
@ 2015-01-22 20:38 ` Marek Belisko
  2015-01-22 20:38 ` [PATCH 05/13] ARM: dts: omap3-gta04: Fix a GPIO line for bma180 node Marek Belisko
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 19+ messages in thread
From: Marek Belisko @ 2015-01-22 20:38 UTC (permalink / raw)
  To: bcousson, tony
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, hns,
	neilb

From: "H. Nikolaus Schaller" <hns@goldelico.com>

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 7272591..fd6ac80 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -205,6 +205,7 @@
 
 		twl_audio: audio {
 			compatible = "ti,twl4030-audio";
+			ti,enable-vibra = <1>;
 			codec {
 			};
 		};
-- 
1.9.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 05/13] ARM: dts: omap3-gta04: Fix a GPIO line for bma180 node
  2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
                   ` (3 preceding siblings ...)
  2015-01-22 20:38 ` [PATCH 04/13] ARM: dts: omap3-gta04: Enable twl audio vibra support Marek Belisko
@ 2015-01-22 20:38 ` Marek Belisko
  2015-01-22 20:38 ` [PATCH 06/13] ARM: dts: omap3-gta04: Enable power-off using twl4030 Marek Belisko
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 19+ messages in thread
From: Marek Belisko @ 2015-01-22 20:38 UTC (permalink / raw)
  To: bcousson, tony
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, hns,
	neilb, Marek Belisko

GPIO_115 used as irq is in &gpio4, not &gpio3.

Signed-off-by: Marek Belisko <marek@goldelico.com>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index fd6ac80..0265474 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -230,7 +230,7 @@
 	bma180@41 {
 		compatible = "bosch,bma180";
 		reg = <0x41>;
-		interrupt-parent = <&gpio3>;
+		interrupt-parent = <&gpio4>;
 		interrupts = <19 IRQ_TYPE_LEVEL_HIGH>;
 	};
 
-- 
1.9.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 06/13] ARM: dts: omap3-gta04: Enable power-off using twl4030
  2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
                   ` (4 preceding siblings ...)
  2015-01-22 20:38 ` [PATCH 05/13] ARM: dts: omap3-gta04: Fix a GPIO line for bma180 node Marek Belisko
@ 2015-01-22 20:38 ` Marek Belisko
  2015-01-22 21:37   ` Tony Lindgren
  2015-01-22 20:38 ` [PATCH 07/13] ARM: dts: omap3-gta04: Add ramp value for twl4030 audio Marek Belisko
                   ` (7 subsequent siblings)
  13 siblings, 1 reply; 19+ messages in thread
From: Marek Belisko @ 2015-01-22 20:38 UTC (permalink / raw)
  To: bcousson, tony
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, hns,
	neilb

From: "H. Nikolaus Schaller" <hns@goldelico.com>

Enabled poweroff through PMIC on GTA04.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 0265474..b56c85b 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -209,6 +209,11 @@
 			codec {
 			};
 		};
+
+		twl_power: power {
+			compatible = "ti,twl4030-power";
+			ti,use_poweroff;
+		};
 	};
 };
 
-- 
1.9.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 07/13] ARM: dts: omap3-gta04: Add ramp value for twl4030 audio
  2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
                   ` (5 preceding siblings ...)
  2015-01-22 20:38 ` [PATCH 06/13] ARM: dts: omap3-gta04: Enable power-off using twl4030 Marek Belisko
@ 2015-01-22 20:38 ` Marek Belisko
  2015-01-22 20:38 ` [PATCH 08/13] ARM: dts: omap3-gta04: add comments about gpios Marek Belisko
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 19+ messages in thread
From: Marek Belisko @ 2015-01-22 20:38 UTC (permalink / raw)
  To: bcousson, tony
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, hns,
	neilb, Marek Belisko

Signed-off-by: Marek Belisko <marek@goldelico.com>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index b56c85b..6f5fcbb 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -207,6 +207,7 @@
 			compatible = "ti,twl4030-audio";
 			ti,enable-vibra = <1>;
 			codec {
+				ti,ramp_delay_value = <3>;
 			};
 		};
 
-- 
1.9.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 08/13] ARM: dts: omap3-gta04: add comments about gpios
  2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
                   ` (6 preceding siblings ...)
  2015-01-22 20:38 ` [PATCH 07/13] ARM: dts: omap3-gta04: Add ramp value for twl4030 audio Marek Belisko
@ 2015-01-22 20:38 ` Marek Belisko
  2015-01-22 20:38 ` [PATCH 09/13] ARM: dts: omap3-gta04: enable power-off for wifi card Marek Belisko
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 19+ messages in thread
From: Marek Belisko @ 2015-01-22 20:38 UTC (permalink / raw)
  To: bcousson, tony
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, hns,
	neilb, NeilBrown

From: NeilBrown <neil@brown.name>

Add comments to state which GPIO is used for some interrupts.

Signed-off-by: NeilBrown <neil@brown.name>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 6f5fcbb..b65b5ed 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -229,7 +229,7 @@
 		compatible = "bosch,bmp085";
 		reg = <0x77>;
 		interrupt-parent = <&gpio4>;
-		interrupts = <17 IRQ_TYPE_EDGE_RISING>;
+		interrupts = <17 IRQ_TYPE_EDGE_RISING>; /* GPIO_113 */
 	};
 
 	/* accelerometer */
@@ -237,7 +237,7 @@
 		compatible = "bosch,bma180";
 		reg = <0x41>;
 		interrupt-parent = <&gpio4>;
-		interrupts = <19 IRQ_TYPE_LEVEL_HIGH>;
+		interrupts = <19 IRQ_TYPE_LEVEL_HIGH>; /* GPIO_115 */
 	};
 
 	/* leds */
@@ -288,7 +288,7 @@
 		compatible = "ti,tsc2007";
 		reg = <0x48>;
 		interrupt-parent = <&gpio6>;
-		interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
+		interrupts = <0 IRQ_TYPE_EDGE_FALLING>; /* GPIO_160 */
 		gpios = <&gpio6 0 GPIO_ACTIVE_LOW>;
 		ti,x-plate-ohms = <600>;
 	};
-- 
1.9.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 09/13] ARM: dts: omap3-gta04: enable power-off for wifi card.
  2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
                   ` (7 preceding siblings ...)
  2015-01-22 20:38 ` [PATCH 08/13] ARM: dts: omap3-gta04: add comments about gpios Marek Belisko
@ 2015-01-22 20:38 ` Marek Belisko
  2015-01-22 20:38 ` [PATCH 10/13] ARM: dts: omap3-gta04: add gyroscope Marek Belisko
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 19+ messages in thread
From: Marek Belisko @ 2015-01-22 20:38 UTC (permalink / raw)
  To: bcousson, tony
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, hns,
	neilb, NeilBrown

From: NeilBrown <neil@brown.name>

Signed-off-by: NeilBrown <neil@brown.name>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index b65b5ed..ab5dd98 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -327,6 +327,7 @@
 	vmmc-supply = <&vaux4>;
 	bus-width = <4>;
 	ti,non-removable;
+	cap-power-off-card;
 };
 
 &mmc3 {
-- 
1.9.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 10/13] ARM: dts: omap3-gta04: add gyroscope
  2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
                   ` (8 preceding siblings ...)
  2015-01-22 20:38 ` [PATCH 09/13] ARM: dts: omap3-gta04: enable power-off for wifi card Marek Belisko
@ 2015-01-22 20:38 ` Marek Belisko
  2015-01-22 20:38 ` [PATCH 11/13] ARM: dts: omap3-gta04: only power DSS when necessary Marek Belisko
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 19+ messages in thread
From: Marek Belisko @ 2015-01-22 20:38 UTC (permalink / raw)
  To: bcousson, tony
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, hns,
	neilb, NeilBrown

From: NeilBrown <neil@brown.name>

Signed-off-by: NeilBrown <neil@brown.name>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index ab5dd98..08f0b25 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -240,6 +240,14 @@
 		interrupts = <19 IRQ_TYPE_LEVEL_HIGH>; /* GPIO_115 */
 	};
 
+	/* gyroscope */
+	itg3200@68 {
+		compatible = "invensense,itg3200";
+		reg = <0x68>;
+		interrupt-parent = <&gpio2>;
+		interrupts = <24 0>; /* GPIO_56 */
+	};
+
 	/* leds */
 	tca6507@45 {
 		compatible = "ti,tca6507";
-- 
1.9.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 11/13] ARM: dts: omap3-gta04: only power DSS when necessary.
  2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
                   ` (9 preceding siblings ...)
  2015-01-22 20:38 ` [PATCH 10/13] ARM: dts: omap3-gta04: add gyroscope Marek Belisko
@ 2015-01-22 20:38 ` Marek Belisko
  2015-01-22 20:38 ` [PATCH 12/13] ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled" Marek Belisko
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 19+ messages in thread
From: Marek Belisko @ 2015-01-22 20:38 UTC (permalink / raw)
  To: bcousson, tony
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, hns,
	neilb, NeilBrown

From: NeilBrown <neil@brown.name>

i.e. configure vpll2 as a supply for the dss rather
than being always-on.

Signed-off-by: NeilBrown <neil@brown.name>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 08f0b25..228e79b 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -393,16 +393,12 @@
 	regulator-max-microvolt = <3150000>;
 };
 
-/* Needed to power the DPI pins */
-&vpll2 {
-	regulator-always-on;
-};
-
 &dss {
 	pinctrl-names = "default";
 	pinctrl-0 = < &dss_dpi_pins >;
 
 	status = "okay";
+	vdds_dsi-supply = <&vpll2>;
 
 	port {
 		dpi_out: endpoint {
-- 
1.9.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 12/13] ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled"
  2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
                   ` (10 preceding siblings ...)
  2015-01-22 20:38 ` [PATCH 11/13] ARM: dts: omap3-gta04: only power DSS when necessary Marek Belisko
@ 2015-01-22 20:38 ` Marek Belisko
  2015-01-22 21:40   ` Tony Lindgren
  2015-01-22 20:38 ` [PATCH 13/13] ARM: dts: omap3-gta04: Disable keypad Marek Belisko
  2015-01-26 20:51 ` [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Tony Lindgren
  13 siblings, 1 reply; 19+ messages in thread
From: Marek Belisko @ 2015-01-22 20:38 UTC (permalink / raw)
  To: bcousson, tony
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, hns,
	neilb, NeilBrown

From: NeilBrown <neil@brown.name>

Signed-off-by: NeilBrown <neil@brown.name>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 228e79b..8d2b0a1 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -357,6 +357,10 @@
 	pinctrl-0 = <&uart3_pins>;
 };
 
+&uart4 {
+	status = "disabled";
+};
+
 &charger {
 	ti,bb-uvolt = <3200000>;
 	ti,bb-uamp = <150>;
-- 
1.9.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH 13/13] ARM: dts: omap3-gta04: Disable keypad
  2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
                   ` (11 preceding siblings ...)
  2015-01-22 20:38 ` [PATCH 12/13] ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled" Marek Belisko
@ 2015-01-22 20:38 ` Marek Belisko
  2015-01-26 20:51 ` [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Tony Lindgren
  13 siblings, 0 replies; 19+ messages in thread
From: Marek Belisko @ 2015-01-22 20:38 UTC (permalink / raw)
  To: bcousson, tony
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
	linux-omap, devicetree, linux-arm-kernel, linux-kernel, hns,
	neilb, NeilBrown

From: NeilBrown <neil@brown.name>

The twl4030 keypad is not wired up in the gta04, so mark it disabled
to avoid pointless initialization.

Signed-off-by: NeilBrown <neil@brown.name>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 8d2b0a1..b3ecf1f 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -342,6 +342,10 @@
 	status = "disabled";
 };
 
+&twl_keypad {
+	status = "disabled";
+};
+
 &uart1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart1_pins>;
-- 
1.9.1


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 06/13] ARM: dts: omap3-gta04: Enable power-off using twl4030
  2015-01-22 20:38 ` [PATCH 06/13] ARM: dts: omap3-gta04: Enable power-off using twl4030 Marek Belisko
@ 2015-01-22 21:37   ` Tony Lindgren
  0 siblings, 0 replies; 19+ messages in thread
From: Tony Lindgren @ 2015-01-22 21:37 UTC (permalink / raw)
  To: Marek Belisko
  Cc: bcousson, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
	galak, linux-omap, devicetree, linux-arm-kernel, linux-kernel,
	hns, neilb

* Marek Belisko <marek@goldelico.com> [150122 12:42]:
> From: "H. Nikolaus Schaller" <hns@goldelico.com>
> 
> Enabled poweroff through PMIC on GTA04.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
>  arch/arm/boot/dts/omap3-gta04.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
> index 0265474..b56c85b 100644
> --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> @@ -209,6 +209,11 @@
>  			codec {
>  			};
>  		};
> +
> +		twl_power: power {
> +			compatible = "ti,twl4030-power";
> +			ti,use_poweroff;
> +		};
>  	};
>  };
>  

No need to change this patch, but you may want to get things working
with ti,twl4030-power-idle-osc-off for PM if you're running it on
batteries :)

Regards,

Tony

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 12/13] ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled"
  2015-01-22 20:38 ` [PATCH 12/13] ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled" Marek Belisko
@ 2015-01-22 21:40   ` Tony Lindgren
  2015-01-23 22:28     ` NeilBrown
  0 siblings, 1 reply; 19+ messages in thread
From: Tony Lindgren @ 2015-01-22 21:40 UTC (permalink / raw)
  To: Marek Belisko
  Cc: bcousson, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
	galak, linux-omap, devicetree, linux-arm-kernel, linux-kernel,
	hns, neilb, NeilBrown

* Marek Belisko <marek@goldelico.com> [150122 12:42]:
> From: NeilBrown <neil@brown.name>
> 
> Signed-off-by: NeilBrown <neil@brown.name>
> ---
>  arch/arm/boot/dts/omap3-gta04.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
> index 228e79b..8d2b0a1 100644
> --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> @@ -357,6 +357,10 @@
>  	pinctrl-0 = <&uart3_pins>;
>  };
>  
> +&uart4 {
> +	status = "disabled";
> +};
> +

This you probably want to avoid from PM point of view. Depending on
bootloader state of uart4, Linux may or may not be able to hit any
deeper power states.

Marking something with status = "disabled" in dts causes the device
entry not even to be created. That means hwmod won't be able to reset
and idle this device during boot.

The uart4 device is there for sure even if not muxed and in incomplete
state. You may want to also check other places where you're using
status = "disabled" for the same reasons.

Regards,

Tony

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 12/13] ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled"
  2015-01-22 21:40   ` Tony Lindgren
@ 2015-01-23 22:28     ` NeilBrown
  2015-01-24  1:03       ` Tony Lindgren
  0 siblings, 1 reply; 19+ messages in thread
From: NeilBrown @ 2015-01-23 22:28 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Marek Belisko, bcousson, robh+dt, pawel.moll, mark.rutland,
	ijc+devicetree, galak, linux-omap, devicetree, linux-arm-kernel,
	linux-kernel, hns, NeilBrown

[-- Attachment #1: Type: text/plain, Size: 2422 bytes --]

On Thu, 22 Jan 2015 13:40:53 -0800 Tony Lindgren <tony@atomide.com> wrote:

> * Marek Belisko <marek@goldelico.com> [150122 12:42]:
> > From: NeilBrown <neil@brown.name>
> > 
> > Signed-off-by: NeilBrown <neil@brown.name>
> > ---
> >  arch/arm/boot/dts/omap3-gta04.dtsi | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
> > index 228e79b..8d2b0a1 100644
> > --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> > +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> > @@ -357,6 +357,10 @@
> >  	pinctrl-0 = <&uart3_pins>;
> >  };
> >  
> > +&uart4 {
> > +	status = "disabled";
> > +};
> > +
> 
> This you probably want to avoid from PM point of view. Depending on
> bootloader state of uart4, Linux may or may not be able to hit any
> deeper power states.
> 
> Marking something with status = "disabled" in dts causes the device
> entry not even to be created. That means hwmod won't be able to reset
> and idle this device during boot.
> 
> The uart4 device is there for sure even if not muxed and in incomplete
> state. You may want to also check other places where you're using
> status = "disabled" for the same reasons.

That's ... unfortunate.  Would that apply to the MCBSPs too?  They are
disabled by default so you would need to explicitly enable them all for
sensible behaviour....

Hopefully there is some way to mark as device as "this is not used, make sure
it is turned off and stays off" ???

Thanks for the heads-up.  I'll have a look and see exactly what is happening.

BTW, on the topic of OMAP UARTs and power saving...
 I note that there are now two drivers for the OMAP3 UART - omap-serial and
 8250_omap.
 I also note that your commit:

commit a2fc36613ac1af2e92cbed7af80bc72d8114dd50
    ARM: OMAP3: Use manual idle for UARTs because of DMA errata

 is incompatible with omap-serial.  In particular, if I enable runtime
 suspend of the serial port by setting the autosuspend_timeout, then incoming
 characters will no longer wake the port (if I revert your patch incoming
 chars do wake the port).
 This could (I think) be fixed by enabling the RX/CTS interrupt.  However if
 omap-serial is being deprecated, then there probably isn't any point.

 So: what is the longer term expectation for these drivers?  Should we be
 switching over to 8250?

Thanks,
NeilBrown

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 12/13] ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled"
  2015-01-23 22:28     ` NeilBrown
@ 2015-01-24  1:03       ` Tony Lindgren
  0 siblings, 0 replies; 19+ messages in thread
From: Tony Lindgren @ 2015-01-24  1:03 UTC (permalink / raw)
  To: NeilBrown
  Cc: Marek Belisko, bcousson, robh+dt, pawel.moll, mark.rutland,
	ijc+devicetree, galak, linux-omap, devicetree, linux-arm-kernel,
	linux-kernel, hns, NeilBrown

* NeilBrown <neilb@suse.de> [150123 14:31]:
> On Thu, 22 Jan 2015 13:40:53 -0800 Tony Lindgren <tony@atomide.com> wrote:
> > >  
> > > +&uart4 {
> > > +	status = "disabled";
> > > +};
> > > +
> > 
> > This you probably want to avoid from PM point of view. Depending on
> > bootloader state of uart4, Linux may or may not be able to hit any
> > deeper power states.
> > 
> > Marking something with status = "disabled" in dts causes the device
> > entry not even to be created. That means hwmod won't be able to reset
> > and idle this device during boot.
> > 
> > The uart4 device is there for sure even if not muxed and in incomplete
> > state. You may want to also check other places where you're using
> > status = "disabled" for the same reasons.
> 
> That's ... unfortunate.  Would that apply to the MCBSPs too?  They are
> disabled by default so you would need to explicitly enable them all for
> sensible behaviour....

Yeah that applies to all the SoC integrated devices that the bus code
(hwmod) is supposed to reset and idle if unused. Basically anything
that depends on the dev entry being created.
 
> Hopefully there is some way to mark as device as "this is not used, make sure
> it is turned off and stays off" ???

Not currently that I know of :) To do that, we should add something
like status = "incomplete" where the dev entry gets created but the
driver is never probed. And incomplete here meaning that the device
is missing some parts like pins that would make it work properly.
 
> Thanks for the heads-up.  I'll have a look and see exactly what is happening.

OK
 
> BTW, on the topic of OMAP UARTs and power saving...
>  I note that there are now two drivers for the OMAP3 UART - omap-serial and
>  8250_omap.
>  I also note that your commit:
> 
> commit a2fc36613ac1af2e92cbed7af80bc72d8114dd50
>     ARM: OMAP3: Use manual idle for UARTs because of DMA errata
> 
>  is incompatible with omap-serial.  In particular, if I enable runtime
>  suspend of the serial port by setting the autosuspend_timeout, then incoming
>  characters will no longer wake the port (if I revert your patch incoming
>  chars do wake the port).
>  This could (I think) be fixed by enabling the RX/CTS interrupt.  However if
>  omap-serial is being deprecated, then there probably isn't any point.
> 
>  So: what is the longer term expectation for these drivers?  Should we be
>  switching over to 8250?

Yeah you should alredy be able to do it. Hopefully we'll have some
translation layer and the old omap-serial.c can be mostly removed
now that we have 8250 support with runtime PM :)

Regards,

Tony

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes
  2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
                   ` (12 preceding siblings ...)
  2015-01-22 20:38 ` [PATCH 13/13] ARM: dts: omap3-gta04: Disable keypad Marek Belisko
@ 2015-01-26 20:51 ` Tony Lindgren
  13 siblings, 0 replies; 19+ messages in thread
From: Tony Lindgren @ 2015-01-26 20:51 UTC (permalink / raw)
  To: Marek Belisko
  Cc: bcousson, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
	galak, linux-omap, devicetree, linux-arm-kernel, linux-kernel,
	hns, neilb

* Marek Belisko <marek@goldelico.com> [150122 12:41]:
> This series contains fixes for gta04 devicetree. I collected patches
> from H. Nikolaus Schaller + NeilBrown and myself. Patches contains mostly fixes
> + adding new nodes and comments. All changes tested on gta04a4 board.
> 
> H. Nikolaus Schaller (5):
>   ARM: dts: omap3-gta04: Fix backup-battery charging in devicetree file.
>   ARM: dts: omap3-gta04: Fix audio node malformatting
>   ARM: dts: omap3-gta04: Enable mcbps2 necessary for audio
>   ARM: dts: omap3-gta04: Enable twl audio vibra support
>   ARM: dts: omap3-gta04: Enable power-off using twl4030
> 
> Marek Belisko (2):
>   ARM: dts: omap3-gta04: Fix a GPIO line for bma180 node
>   ARM: dts: omap3-gta04: Add ramp value for twl4030 audio
> 
> NeilBrown (6):
>   ARM: dts: omap3-gta04: add comments about gpios
>   ARM: dts: omap3-gta04: enable power-off for wifi card.
>   ARM: dts: omap3-gta04: add gyroscope
>   ARM: dts: omap3-gta04: only power DSS when necessary.
>   ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled"

Applying all except the uart4 "disabled" patch into omap-for-v3.20/dt
thanks.

Tony

>   ARM: dts: omap3-gta04: Disable keypad
> 
>  arch/arm/boot/dts/omap3-gta04.dtsi | 54 +++++++++++++++++++++++++++-----------
>  1 file changed, 39 insertions(+), 15 deletions(-)
> 
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2015-01-26 20:55 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-22 20:38 [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Marek Belisko
2015-01-22 20:38 ` [PATCH 01/13] ARM: dts: omap3-gta04: Fix backup-battery charging in devicetree file Marek Belisko
2015-01-22 20:38 ` [PATCH 02/13] ARM: dts: omap3-gta04: Fix audio node malformatting Marek Belisko
2015-01-22 20:38 ` [PATCH 03/13] ARM: dts: omap3-gta04: Enable mcbps2 necessary for audio Marek Belisko
2015-01-22 20:38 ` [PATCH 04/13] ARM: dts: omap3-gta04: Enable twl audio vibra support Marek Belisko
2015-01-22 20:38 ` [PATCH 05/13] ARM: dts: omap3-gta04: Fix a GPIO line for bma180 node Marek Belisko
2015-01-22 20:38 ` [PATCH 06/13] ARM: dts: omap3-gta04: Enable power-off using twl4030 Marek Belisko
2015-01-22 21:37   ` Tony Lindgren
2015-01-22 20:38 ` [PATCH 07/13] ARM: dts: omap3-gta04: Add ramp value for twl4030 audio Marek Belisko
2015-01-22 20:38 ` [PATCH 08/13] ARM: dts: omap3-gta04: add comments about gpios Marek Belisko
2015-01-22 20:38 ` [PATCH 09/13] ARM: dts: omap3-gta04: enable power-off for wifi card Marek Belisko
2015-01-22 20:38 ` [PATCH 10/13] ARM: dts: omap3-gta04: add gyroscope Marek Belisko
2015-01-22 20:38 ` [PATCH 11/13] ARM: dts: omap3-gta04: only power DSS when necessary Marek Belisko
2015-01-22 20:38 ` [PATCH 12/13] ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled" Marek Belisko
2015-01-22 21:40   ` Tony Lindgren
2015-01-23 22:28     ` NeilBrown
2015-01-24  1:03       ` Tony Lindgren
2015-01-22 20:38 ` [PATCH 13/13] ARM: dts: omap3-gta04: Disable keypad Marek Belisko
2015-01-26 20:51 ` [PATCH 00/13] ARM: dts: omap3-gta04: Various DT fixes Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).