LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v3] i2c: tegra: Maintain CPU endianness
@ 2015-01-26 16:55 Dmitry Osipenko
  2015-01-26 21:00 ` Wolfram Sang
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Osipenko @ 2015-01-26 16:55 UTC (permalink / raw)
  To: digetx, Wolfram Sang, Stephen Warren, Thierry Reding,
	Alexandre Courbot, Laxman Dewangan
  Cc: Ben Dooks, Bob Mottram, linux-tegra, linux-i2c, linux-kernel

Support CPU BE mode by adding endianness conversion for memcpy interactions.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
---
Changelog:
v2: For consistency cpu_to_le32() changed to le32_to_cpu() because
    i2c_writel() takes BE value in BE CPU mode and value is in LE format.
v3: Removed "val = 0;", it turned out it wasn't needed. For some reason
    it wasn't working at first time, hope it was just me doing something
    wrong and it's not a heisenbug. I've checked kernel with all memory
    corruption detection options enabled and it didn't show any problems.

 drivers/i2c/busses/i2c-tegra.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index 28b87e6..29f1433 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -286,6 +286,7 @@ static int tegra_i2c_empty_rx_fifo(struct tegra_i2c_dev *i2c_dev)
 	if (rx_fifo_avail > 0 && buf_remaining > 0) {
 		BUG_ON(buf_remaining > 3);
 		val = i2c_readl(i2c_dev, I2C_RX_FIFO);
+		val = cpu_to_le32(val);
 		memcpy(buf, &val, buf_remaining);
 		buf_remaining = 0;
 		rx_fifo_avail--;
@@ -344,6 +345,7 @@ static int tegra_i2c_fill_tx_fifo(struct tegra_i2c_dev *i2c_dev)
 	if (tx_fifo_avail > 0 && buf_remaining > 0) {
 		BUG_ON(buf_remaining > 3);
 		memcpy(&val, buf, buf_remaining);
+		val = le32_to_cpu(val);
 
 		/* Again update before writing to FIFO to make sure isr sees. */
 		i2c_dev->msg_buf_remaining = 0;
-- 
2.2.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] i2c: tegra: Maintain CPU endianness
  2015-01-26 16:55 [PATCH v3] i2c: tegra: Maintain CPU endianness Dmitry Osipenko
@ 2015-01-26 21:00 ` Wolfram Sang
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2015-01-26 21:00 UTC (permalink / raw)
  To: Dmitry Osipenko
  Cc: Stephen Warren, Thierry Reding, Alexandre Courbot,
	Laxman Dewangan, Ben Dooks, Bob Mottram, linux-tegra, linux-i2c,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

On Mon, Jan 26, 2015 at 07:55:02PM +0300, Dmitry Osipenko wrote:
> Support CPU BE mode by adding endianness conversion for memcpy interactions.
> 
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-26 21:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-26 16:55 [PATCH v3] i2c: tegra: Maintain CPU endianness Dmitry Osipenko
2015-01-26 21:00 ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).