LKML Archive on
help / color / mirror / Atom feed
From: Mark Rutland <>
To: Mika Westerberg <>
Cc: Jiri Kosina <>,
	Benjamin Tissoires <>,
	Rob Herring <>, Pawel Moll <>,
	Ian Campbell <>,
	Kumar Gala <>,
	Jarkko Nikula <>,
	"" <>,
	"" <>,
	Linus Walleij <>,
	Alexandre Courbot <>
Subject: Re: [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts
Date: Tue, 27 Jan 2015 15:06:06 +0000	[thread overview]
Message-ID: <20150127150606.GI17721@leverpostej> (raw)
In-Reply-To: <>

On Tue, Jan 27, 2015 at 02:41:27PM +0000, Mika Westerberg wrote:
> On Tue, Jan 27, 2015 at 02:33:34PM +0000, Mark Rutland wrote:
> > Ok, that allays my fear w.r.t. ordering of the resources.
> > 
> > As I see it, the fact that we convert GpioInt entries to GPIOs rather
> > than irqs when parsing _CRS is the issue here, and to me it makes no
> > sense that we do so. Were we to treat them as interrupts, the binding is
> > fine as-is, and we'd do the same thing in DT and ACPI.
> > 
> > The reason GpioInt is separate from GpioIo is that a GpioInt _is_ an
> > interrupt (which happens to be backed by a GPIO), and is not something
> > that necessarily makes sense as a GPIO.
> I would rather say that GpioInt *is* a GPIO. That can then used as an
> interrupt but it should not prevent you from using it as GPIO instead.
> For example if you just want to poll that something is 0 or 1. That
> should be possible as well and nothing say that you cannot do that for
> GpioInt().

>From my POV a GpioInt is logically an interrupt, or it would be a
GpioIo. That doesn't necessarily mean it's invalid to try to query its
state as a GPIO, but I do not think that it makes sense to handle it by
default as a GPIO given that it was handed to us as a GpioInt so that it
can be used as an interrupt.

If it's just the case that ACPI and DT differ w.r.t. how this case (an
interrupt line wired to a GPIO) is described, that in itself is fine;
different standards have different models.

However, I do not think we must change the DT binding and violate
established DT practice simply becuase on the ACPI side things are
different (nor would it make sense to do things the other way around).
If the two have different rules, then we should handle those rules
separately rather than trying to force the two together when they
clearly don't fit.

In the driver that can easily be achieved with separate probe paths.
W.R.T. the DT binding, I do not think it makes sense to pretend this
is also an ACPI binding.


  reply	other threads:[~2015-01-27 15:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 14:29 [PATCH 1/2] HID: i2c-hid: The interrupt should be level sensitive Mika Westerberg
2015-01-26 14:29 ` [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts Mika Westerberg
2015-01-26 14:37   ` Mark Rutland
2015-01-26 14:47     ` Mika Westerberg
2015-01-26 14:50       ` Mark Rutland
2015-01-26 15:16         ` Mika Westerberg
2015-01-26 16:01           ` Mark Rutland
2015-01-26 16:13             ` Mika Westerberg
2015-01-26 16:39               ` Mark Rutland
2015-01-27 10:16                 ` Mika Westerberg
2015-01-27 10:39                   ` Mark Rutland
2015-01-27 10:59                     ` Mika Westerberg
2015-01-27 11:14                       ` Mark Rutland
2015-01-27 11:30                         ` Mika Westerberg
2015-01-27 14:33                           ` Mark Rutland
2015-01-27 14:41                             ` Mika Westerberg
2015-01-27 15:06                               ` Mark Rutland [this message]
2015-01-27 15:21                                 ` Mika Westerberg
2015-01-27 15:57                                   ` Mark Rutland
2015-01-27 17:10                                     ` Mika Westerberg
2015-01-29 20:09 ` [PATCH 1/2] HID: i2c-hid: The interrupt should be level sensitive Benjamin Tissoires
2015-02-17 12:24   ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150127150606.GI17721@leverpostej \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).