LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Ingo Molnar <mingo@kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Jason Low <jason.low2@hp.com>,
Michel Lespinasse <walken@google.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 3/6] locking/rwsem: Set lock ownership ASAP
Date: Tue, 27 Jan 2015 18:10:21 +0100 [thread overview]
Message-ID: <20150127171021.GJ21418@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1422257769-14083-4-git-send-email-dave@stgolabs.net>
On Sun, Jan 25, 2015 at 11:36:06PM -0800, Davidlohr Bueso wrote:
> In order to optimize the spinning step, we need to set the lock
> owner as soon as the lock is acquired; after a successful counter
> cmpxchg operation, that is. This is particularly useful as rwsems
> need to set the owner to nil for readers, so there is a greater
> chance of falling out of the spinning. Currently we only set the
> owner much later in the game, in the more generic level -- latency
> can be specially bad when waiting for a node->next pointer when
> releasing the osq in up_write calls.
>
> As such, update the owner inside rwsem_try_write_lock (when the
> lock is obtained after blocking) and rwsem_try_write_lock_unqueued
> (when the lock is obtained while spinning). This requires creating
> a new internal rwsem.h header to share the owner related calls.
>
> Also cleanup some headers for mutex and rwsem.
This is the thing I suggested
lkml.kernel.org/r/20150108103708.GE29390@twins.programming.kicks-ass.net
there right?
Do you have numbers for how much this gained?
next prev parent reply other threads:[~2015-01-27 17:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 7:36 [PATCH -tip 0/6] rwsem: Fine tuning Davidlohr Bueso
2015-01-26 7:36 ` [PATCH 1/6] locking/rwsem: Use task->state helpers Davidlohr Bueso
2015-02-04 14:38 ` [tip:locking/core] " tip-bot for Davidlohr Bueso
2015-01-26 7:36 ` [PATCH 2/6] locking/rwsem: Document barrier need when waking tasks Davidlohr Bueso
2015-01-27 17:07 ` Peter Zijlstra
2015-01-27 20:30 ` Davidlohr Bueso
2015-01-26 7:36 ` [PATCH 3/6] locking/rwsem: Set lock ownership ASAP Davidlohr Bueso
2015-01-27 17:10 ` Peter Zijlstra [this message]
2015-01-27 19:18 ` Davidlohr Bueso
2015-01-26 7:36 ` [PATCH 4/6] locking/rwsem: Avoid deceiving lock spinners Davidlohr Bueso
2015-01-27 17:23 ` Jason Low
2015-01-28 3:54 ` Davidlohr Bueso
2015-01-28 17:01 ` Tim Chen
2015-01-28 21:03 ` Jason Low
2015-01-29 1:10 ` Davidlohr Bueso
2015-01-29 20:13 ` Jason Low
2015-01-29 20:18 ` Jason Low
2015-01-29 23:15 ` Davidlohr Bueso
2015-01-30 1:52 ` Refactoring mutex spin on owner code Jason Low
2015-01-30 7:14 ` Davidlohr Bueso
2015-01-30 7:51 ` Peter Zijlstra
2015-01-26 7:36 ` [PATCH 5/6] locking/rwsem: Optimize slowpath/sleeping Davidlohr Bueso
2015-01-27 17:34 ` Peter Zijlstra
2015-01-27 21:57 ` Davidlohr Bueso
2015-01-26 7:36 ` [PATCH 6/6] locking/rwsem: Check for active lock before bailing on spinning Davidlohr Bueso
2015-01-27 18:11 ` Jason Low
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127171021.GJ21418@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=jason.low2@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tim.c.chen@linux.intel.com \
--cc=walken@google.com \
--subject='Re: [PATCH 3/6] locking/rwsem: Set lock ownership ASAP' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).