LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] usb: phy-generic: Don't fail on missing gpio reset
@ 2015-01-27  1:45 Soren Brinkmann
  2015-01-27 15:20 ` Felipe Balbi
  2015-01-27 15:24 ` Arnd Bergmann
  0 siblings, 2 replies; 5+ messages in thread
From: Soren Brinkmann @ 2015-01-27  1:45 UTC (permalink / raw)
  To: Andreas Färber
  Cc: Michal Simek, devicetree, Peter Crosthwaite, Arnd Bergmann,
	linux-kernel, linux-arm-kernel, Ola Jeppson, linux-gpio,
	linux-usb, Felipe Balbi, Soren Brinkmann

A reset through a GPIO is optional. Don't fail probing when it is
missing.

Reported-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
Hi Andreas,

does this do the trick?

	Thanks,
	Sören

 drivers/usb/phy/phy-generic.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
index dd05254241fb..a73d4c738f0b 100644
--- a/drivers/usb/phy/phy-generic.c
+++ b/drivers/usb/phy/phy-generic.c
@@ -241,10 +241,8 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop,
 
 	if (err == -EPROBE_DEFER)
 		return -EPROBE_DEFER;
-	if (err) {
-		dev_err(dev, "Error requesting RESET GPIO\n");
-		return err;
-	}
+	if (err)
+		nop->gpiod_reset = NULL;
 
 	nop->phy.otg = devm_kzalloc(dev, sizeof(*nop->phy.otg),
 			GFP_KERNEL);
-- 
2.2.2.1.g63c5777


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-01-27 19:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-27  1:45 [PATCH] usb: phy-generic: Don't fail on missing gpio reset Soren Brinkmann
2015-01-27 15:20 ` Felipe Balbi
2015-01-27 19:13   ` Sören Brinkmann
2015-01-27 19:14     ` Felipe Balbi
2015-01-27 15:24 ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).