LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rabin Vincent <rabin@rab.in>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] module: set ksymtab/kcrctab* section addresses to 0x0
Date: Tue, 27 Jan 2015 20:52:13 +0100	[thread overview]
Message-ID: <20150127195213.GA3151@dator> (raw)
In-Reply-To: <87d261rtiv.fsf@rustcorp.com.au>

On Tue, Jan 27, 2015 at 10:20:32AM +1030, Rusty Russell wrote:
> Rabin Vincent <rabin.vincent@axis.com> writes:
> > These __ksymtab*/__kcrctab* sections currently have non-zero addresses.
> > Non-zero section addresses in a relocatable ELF confuse GDB and it ends
> > up not relocating all symbols when add-symbol-file is used on modules
> > which have exports.  The kernel's module loader does not care about
> > these addresses, so let's just set them to zero.
> 
>         You're right, we don't use sh_addr.  This should be safe, I've
> applied it for the next merge window.

Thanks.

> AFAICT this would have always been a problem; wonder if it should be
> CC:stable?  I don't use gdb on modules so haven't got a good feel for
> how many people this would be hurting.

I've no opinion on -stable.  This method of debugging kernel modules is
described in for example LDD3, so it would be nice if it worked in all
cases, but I guess most people won't be affected even if they use it
since it only affects modules with exported symbols.

      reply	other threads:[~2015-01-27 19:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 20:45 Rabin Vincent
2015-01-26 23:50 ` Rusty Russell
2015-01-27 19:52   ` Rabin Vincent [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150127195213.GA3151@dator \
    --to=rabin@rab.in \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --subject='Re: [PATCH] module: set ksymtab/kcrctab* section addresses to 0x0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).