From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752860AbbA1ULu (ORCPT ); Wed, 28 Jan 2015 15:11:50 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:59202 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbbA1ULP (ORCPT ); Wed, 28 Jan 2015 15:11:15 -0500 Date: Wed, 28 Jan 2015 13:30:38 -0600 From: Benoit Parrot To: Paul Walmsley CC: "Lad, Prabhakar" , Tony Lindgren , LAK , Linux OMAP Mailing List , LKML , Darren Etheridge , Felipe Balbi Subject: Re: [PATCH v2] ARM: AM43xx: hwmod: add VPFE hwmod entries Message-ID: <20150128193038.GG2570@ti.com> References: <1422217915-24231-1-git-send-email-prabhakar.csengg@gmail.com> <20150126155032.GD2570@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul Walmsley wrote on Mon [2015-Jan-26 18:47:11 +0000]: > Hi Prabhakar, > > On Mon, 26 Jan 2015, Lad, Prabhakar wrote: > > > Hi Benoit, > > > > On Mon, Jan 26, 2015 at 3:50 PM, Benoit Parrot wrote: > > > Lad, Prabhakar wrote on Mon [2015-Jan-26 08:13:01 +0000]: > > >> Hi Paul, > > >> > > >> Thanks for the review. > > >> > > >> On Mon, Jan 26, 2015 at 2:15 AM, Paul Walmsley wrote: > > >> > Hi > > >> > > > >> > On Sun, 25 Jan 2015, Lad, Prabhakar wrote: > > >> > > > >> >> From: Benoit Parrot > > >> >> > > >> >> this patch adds VPFE HWMOD data for AM43xx. > > >> >> > > >> >> Signed-off-by: Benoit Parrot > > >> >> Signed-off-by: Darren Etheridge > > >> >> Signed-off-by: Felipe Balbi > > >> >> Signed-off-by: Lad, Prabhakar > > >> >> --- > > >> >> Hi Paul, > > >> >> > > >> >> You were right, the hardware team has confirmed that, the VPFE master port is > > >> >> connected to L3 and the VPFE slave port is connected to L4. The L3 port cannot > > >> >> serve as a register target because it is initiator only. > > >> > > > >> > OK makes sense to me., > > >> > > > >> >> > > >> >> I have created links referring to dss l3/l4 hwmod and tested it, lemme know > > >> >> if I have missed something. > > >> > > > >> > A few minor comments below > > >> > > > >> >> > > >> [Snip] > > >> >> /* Interfaces */ > > >> >> static struct omap_hwmod_ocp_if am43xx_l3_main__l4_hs = { > > >> >> .master = &am33xx_l3_main_hwmod, > > >> >> @@ -788,6 +826,36 @@ static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_rfbi = { > > >> >> .user = OCP_USER_MPU | OCP_USER_SDMA, > > >> >> }; > > >> >> > > >> >> +static struct omap_hwmod_ocp_if am43xx_l3__vpfe0 = { > > >> >> + .master = &am43xx_vpfe0_hwmod, > > >> >> + .slave = &am33xx_l3_main_hwmod, > > >> >> + .clk = "l3_gclk", > > >> >> + .flags = OCPIF_SWSUP_IDLE, > > >> > > > >> > OCPIF_SWSUP_IDLE probably isn't needed here. Could you please try without > > >> > it? > > >> > > > >> >> + .user = OCP_USER_MPU | OCP_USER_SDMA, > > >> >> +}; > > >> >> + > > >> >> +static struct omap_hwmod_ocp_if am43xx_l3__vpfe1 = { > > >> >> + .master = &am43xx_vpfe1_hwmod, > > >> >> + .slave = &am33xx_l3_main_hwmod, > > >> >> + .clk = "l3_gclk", > > >> >> + .flags = OCPIF_SWSUP_IDLE, > > >> > > > >> > Same point as the above. > > >> > > > >> Dropped and tested works! posting a v3. > > > > > > When you tested it without the OCPIF_SWSUP_IDLE, did you go trhough a complete suspend/resume cycle? > > > This flag was added early on because otherwise the susbsytem would not go idle without it... > > > > > > Can you post the console output during a suspend/resume cycle? > > > > > Ah I didn’t test the suspend/resume will do and post the console log. > > Could you also do a suspend/resume test on v2? Prabbhakar, I tested both v2 and v3 and both successfully went through a suspend/resume cycle. So I guess v3 is fine, sorry for the noise. I'll add a tested-by on V3. Benoit > > thanks > > - Paul