LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Russell King <linux@arm.linux.org.uk>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH 0/2] Fix secondary CPU boot for thumb2 kernels
Date: Thu, 29 Jan 2015 15:46:25 +0000	[thread overview]
Message-ID: <20150129154624.GH8951@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <54C94511.30508@codeaurora.org>

On Wed, Jan 28, 2015 at 08:22:41PM +0000, Stephen Boyd wrote:
> On 01/21/15 11:48, Stephen Boyd wrote:
> > Currently I can't boot up secondary CPUs on qcom platforms when I
> > compile the kernel for THUMB2 mode. This is because we always enter
> > the kernel in ARM mode regardless of what mode the kernel is compiled
> > for. This patchset adds a small wrapper to secondary_startup() called
> > secondary_startup_arm() that allows us to switch into THUMB2 mode if
> > we need to. If the kernel is compiled for ARM mode it shouldn't have
> > any effect.
> >
> > Stephen Boyd (2):
> >   ARM: Add a secondary_startup that assumes ARM mode
> >   ARM: qcom: Use secondary_startup_arm()
> >
> >  arch/arm/kernel/head.S       | 7 +++++++
> >  arch/arm/mach-qcom/platsmp.c | 4 ++--
> >  2 files changed, 9 insertions(+), 2 deletions(-)
> 
> Any comments here? Perhaps I can send this through the patch tracker?

FWIW, they look fine to me.

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

I guess the reason it works fine on other platforms is because the
secondary start address we pass to firmware has bit 0 set and this
causes the jump to the kernel in Thumb-2 mode.

Catalin

  reply	other threads:[~2015-01-29 15:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21 19:48 Stephen Boyd
2015-01-21 19:48 ` [PATCH 1/2] ARM: Add a secondary_startup that assumes ARM mode Stephen Boyd
2015-01-21 19:48 ` [PATCH 2/2] ARM: qcom: Use secondary_startup_arm() Stephen Boyd
2015-01-28 20:22 ` [PATCH 0/2] Fix secondary CPU boot for thumb2 kernels Stephen Boyd
2015-01-29 15:46   ` Catalin Marinas [this message]
2015-01-29 21:29     ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150129154624.GH8951@e104818-lin.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=galak@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=sboyd@codeaurora.org \
    --subject='Re: [PATCH 0/2] Fix secondary CPU boot for thumb2 kernels' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).