LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] pcmcia: at91_cf: depend on !ARCH_MULTIPLATFORM
@ 2015-01-13 18:28 Alexandre Belloni
  2015-01-14  9:21 ` Nicolas Ferre
  0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Belloni @ 2015-01-13 18:28 UTC (permalink / raw)
  To: linux-pcmcia
  Cc: Nicolas Ferre, Arnd Bergmann, linux-arm-kernel, linux-kernel,
	Boris Brezillon, Alexandre Belloni

Until the driver is corrected to stop including mach/at91_ramc.h and using
mach/io.h, it won't compile in a ARCH_MULTIPLATFORM configuration.

Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 drivers/pcmcia/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
index 910e90bf16c6..45f67c63d385 100644
--- a/drivers/pcmcia/Kconfig
+++ b/drivers/pcmcia/Kconfig
@@ -276,6 +276,7 @@ config BFIN_CFPCMCIA
 config AT91_CF
 	tristate "AT91 CompactFlash Controller"
 	depends on PCMCIA && ARCH_AT91
+	depends on !ARCH_MULTIPLATFORM
 	help
 	  Say Y here to support the CompactFlash controller on AT91 chips.
 	  Or choose M to compile the driver as a module named "at91_cf".
-- 
2.1.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pcmcia: at91_cf: depend on !ARCH_MULTIPLATFORM
  2015-01-13 18:28 [PATCH] pcmcia: at91_cf: depend on !ARCH_MULTIPLATFORM Alexandre Belloni
@ 2015-01-14  9:21 ` Nicolas Ferre
  2015-01-29  9:40   ` Nicolas Ferre
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Ferre @ 2015-01-14  9:21 UTC (permalink / raw)
  To: Alexandre Belloni, linux-pcmcia
  Cc: Arnd Bergmann, linux-arm-kernel, linux-kernel, Boris Brezillon

Le 13/01/2015 19:28, Alexandre Belloni a écrit :
> Until the driver is corrected to stop including mach/at91_ramc.h and using
> mach/io.h, it won't compile in a ARCH_MULTIPLATFORM configuration.
> 
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---
>  drivers/pcmcia/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
> index 910e90bf16c6..45f67c63d385 100644
> --- a/drivers/pcmcia/Kconfig
> +++ b/drivers/pcmcia/Kconfig
> @@ -276,6 +276,7 @@ config BFIN_CFPCMCIA
>  config AT91_CF
>  	tristate "AT91 CompactFlash Controller"
>  	depends on PCMCIA && ARCH_AT91
> +	depends on !ARCH_MULTIPLATFORM
>  	help
>  	  Say Y here to support the CompactFlash controller on AT91 chips.
>  	  Or choose M to compile the driver as a module named "at91_cf".
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pcmcia: at91_cf: depend on !ARCH_MULTIPLATFORM
  2015-01-14  9:21 ` Nicolas Ferre
@ 2015-01-29  9:40   ` Nicolas Ferre
  2015-01-29 18:58     ` Olof Johansson
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Ferre @ 2015-01-29  9:40 UTC (permalink / raw)
  To: Alexandre Belloni, Arnd Bergmann, Olof Johansson, ARM Maintainers
  Cc: linux-pcmcia, Boris Brezillon, linux-arm-kernel, linux-kernel

Le 14/01/2015 10:21, Nicolas Ferre a écrit :
> Le 13/01/2015 19:28, Alexandre Belloni a écrit :
>> Until the driver is corrected to stop including mach/at91_ramc.h and using
>> mach/io.h, it won't compile in a ARCH_MULTIPLATFORM configuration.
>>
>> Suggested-by: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Arnd, Olof, Kevin,

It seems that nobody is taking this lonely patch. It can be interesting
to have it for 3.20.
So, can you please add it to the "drivers" branch so that the switch to
multi-platform is possible soon.

Here is the reference of it in patchwork:

https://patchwork.kernel.org/patch/5623391/

Tell me if it's better to ask Greg or Andrew.

Bye,

>> ---
>>  drivers/pcmcia/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
>> index 910e90bf16c6..45f67c63d385 100644
>> --- a/drivers/pcmcia/Kconfig
>> +++ b/drivers/pcmcia/Kconfig
>> @@ -276,6 +276,7 @@ config BFIN_CFPCMCIA
>>  config AT91_CF
>>  	tristate "AT91 CompactFlash Controller"
>>  	depends on PCMCIA && ARCH_AT91
>> +	depends on !ARCH_MULTIPLATFORM
>>  	help
>>  	  Say Y here to support the CompactFlash controller on AT91 chips.
>>  	  Or choose M to compile the driver as a module named "at91_cf".
>>
> 
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pcmcia: at91_cf: depend on !ARCH_MULTIPLATFORM
  2015-01-29  9:40   ` Nicolas Ferre
@ 2015-01-29 18:58     ` Olof Johansson
  0 siblings, 0 replies; 4+ messages in thread
From: Olof Johansson @ 2015-01-29 18:58 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: Alexandre Belloni, Arnd Bergmann, ARM Maintainers, linux-pcmcia,
	Boris Brezillon, linux-arm-kernel, linux-kernel

On Thu, Jan 29, 2015 at 10:40:49AM +0100, Nicolas Ferre wrote:
> Le 14/01/2015 10:21, Nicolas Ferre a écrit :
> > Le 13/01/2015 19:28, Alexandre Belloni a écrit :
> >> Until the driver is corrected to stop including mach/at91_ramc.h and using
> >> mach/io.h, it won't compile in a ARCH_MULTIPLATFORM configuration.
> >>
> >> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> >> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > 
> > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> 
> Arnd, Olof, Kevin,
> 
> It seems that nobody is taking this lonely patch. It can be interesting
> to have it for 3.20.
> So, can you please add it to the "drivers" branch so that the switch to
> multi-platform is possible soon.
> 
> Here is the reference of it in patchwork:
> 
> https://patchwork.kernel.org/patch/5623391/
> 
> Tell me if it's better to ask Greg or Andrew.

This is small and trivial enough that I think we can just take it. Applied to
next/drivers.


-Olof

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-01-29 18:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-13 18:28 [PATCH] pcmcia: at91_cf: depend on !ARCH_MULTIPLATFORM Alexandre Belloni
2015-01-14  9:21 ` Nicolas Ferre
2015-01-29  9:40   ` Nicolas Ferre
2015-01-29 18:58     ` Olof Johansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).