LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()
@ 2015-01-29 22:11 Heba Aamer
  2015-01-30  2:02 ` Larry Finger
  0 siblings, 1 reply; 2+ messages in thread
From: Heba Aamer @ 2015-01-29 22:11 UTC (permalink / raw)
  To: devel
  Cc: Larry.Finger, florian.c.schilhabel, gregkh, tapaswenipathak,
	thomas, sudipm.mukherjee, rickard_strandqvist, linux-kernel

This patch fixes the following checkpatch.pl warning:
Prefer ether_addr_copy() over memcpy()
if the Ethernet addresses are __aligned(2)

pahole showed that the struct used pnetdev->dev_addr
is aligned to u16.

Moreover mac is a simple array, pdata is a pointer that
starts from an even offset.

Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
---
v2: modifying patch description

 drivers/staging/rtl8712/usb_intf.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
index 15f0d42..a2f2dfb 100644
--- a/drivers/staging/rtl8712/usb_intf.c
+++ b/drivers/staging/rtl8712/usb_intf.c
@@ -463,7 +463,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
 				/* Use the mac address stored in the Efuse
 				 * offset = 0x12 for usb in efuse
 				 */
-				memcpy(mac, &pdata[0x12], ETH_ALEN);
+				ether_addr_copy(mac, &pdata[0x12]);
 			}
 			eeprom_CustomerID = pdata[0x52];
 			switch (eeprom_CustomerID) {
@@ -580,7 +580,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
 		} else
 			dev_info(&udev->dev,
 				"r8712u: MAC Address from efuse = %pM\n", mac);
-		memcpy(pnetdev->dev_addr, mac, ETH_ALEN);
+		ether_addr_copy(pnetdev->dev_addr, mac);
 	}
 	/* step 6. Load the firmware asynchronously */
 	if (rtl871x_load_fw(padapter))
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()
  2015-01-29 22:11 [PATCH v2] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy() Heba Aamer
@ 2015-01-30  2:02 ` Larry Finger
  0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2015-01-30  2:02 UTC (permalink / raw)
  To: Heba Aamer, devel
  Cc: florian.c.schilhabel, gregkh, tapaswenipathak, thomas,
	sudipm.mukherjee, rickard_strandqvist, linux-kernel

On 01/29/2015 04:11 PM, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl warning:
> Prefer ether_addr_copy() over memcpy()
> if the Ethernet addresses are __aligned(2)
>
> pahole showed that the struct used pnetdev->dev_addr
> is aligned to u16.
>
> Moreover mac is a simple array, pdata is a pointer that
> starts from an even offset.
>
> Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
> ---
> v2: modifying patch description
>
>   drivers/staging/rtl8712/usb_intf.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

This is much better.

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Larry

>
> diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> index 15f0d42..a2f2dfb 100644
> --- a/drivers/staging/rtl8712/usb_intf.c
> +++ b/drivers/staging/rtl8712/usb_intf.c
> @@ -463,7 +463,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
>   				/* Use the mac address stored in the Efuse
>   				 * offset = 0x12 for usb in efuse
>   				 */
> -				memcpy(mac, &pdata[0x12], ETH_ALEN);
> +				ether_addr_copy(mac, &pdata[0x12]);
>   			}
>   			eeprom_CustomerID = pdata[0x52];
>   			switch (eeprom_CustomerID) {
> @@ -580,7 +580,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
>   		} else
>   			dev_info(&udev->dev,
>   				"r8712u: MAC Address from efuse = %pM\n", mac);
> -		memcpy(pnetdev->dev_addr, mac, ETH_ALEN);
> +		ether_addr_copy(pnetdev->dev_addr, mac);
>   	}
>   	/* step 6. Load the firmware asynchronously */
>   	if (rtl871x_load_fw(padapter))
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-30  2:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-29 22:11 [PATCH v2] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy() Heba Aamer
2015-01-30  2:02 ` Larry Finger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).