From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758630AbbA3ORX (ORCPT ); Fri, 30 Jan 2015 09:17:23 -0500 Received: from smtprelay0040.hostedemail.com ([216.40.44.40]:43049 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750852AbbA3ORW (ORCPT ); Fri, 30 Jan 2015 09:17:22 -0500 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1567:1593:1594:1711:1714:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3622:3867:3873:4321:4385:5007:6261:7875:8660:10004:10400:10848:10967:11026:11232:11658:11914:12043:12296:12517:12519:12555:12740:13069:13138:13148:13230:13231:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: grass05_4012b855ff122 X-Filterd-Recvd-Size: 1648 Date: Fri, 30 Jan 2015 09:17:19 -0500 From: Steven Rostedt To: Wang Nan Cc: , , , , , Subject: Re: [PATCH v2 1/3] tools lib traceevent: add priv field to struct format_field. Message-ID: <20150130091719.6464f945@gandalf.local.home> In-Reply-To: <1422268705-32084-2-git-send-email-wangnan0@huawei.com> References: <1422268705-32084-1-git-send-email-wangnan0@huawei.com> <1422268705-32084-2-git-send-email-wangnan0@huawei.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Jan 2015 18:38:23 +0800 Wang Nan wrote: > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c > index cf3a44b..5f76003 100644 > --- a/tools/lib/traceevent/event-parse.c > +++ b/tools/lib/traceevent/event-parse.c > @@ -5909,6 +5909,8 @@ static void free_format_fields(struct format_field *field) > free(field->type); > free(field->name); > free(field); > + if (field->destroy_priv) > + field->destroy_priv(field); I think you want to call field->destroy_priv() *before* you free field. -- Steve > field = next; > } > }