From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758590AbbA3KoV (ORCPT ); Fri, 30 Jan 2015 05:44:21 -0500 Received: from foss-mx-na.foss.arm.com ([217.140.108.86]:46488 "EHLO foss-mx-na.foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753419AbbA3KoP (ORCPT ); Fri, 30 Jan 2015 05:44:15 -0500 Date: Fri, 30 Jan 2015 10:44:11 +0000 From: Lorenzo Pieralisi To: "Yang, Wenyou" Cc: "Ferre, Nicolas" , "linux@arm.linux.org.uk" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "alexandre.belloni@free-electrons.com" , "sylvain.rochet@finsecur.com" , "peda@axentia.se" , "Vilchez, Patrice" Subject: Re: [PATCH 2/7] pm: at91: pm_suspend: add the WFI support for ARMv7 Message-ID: <20150130104411.GD8787@red-moon> References: <1422266617-24381-1-git-send-email-wenyou.yang@atmel.com> <1422266761-24487-1-git-send-email-wenyou.yang@atmel.com> <20150128112551.GA13253@e102568-lin.cambridge.arm.com> <20150129122223.GA3937@red-moon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 30, 2015 at 07:23:21AM +0000, Yang, Wenyou wrote: [...] > > > > > + */ > > > > > + isb > > > > This isb should not be there, unless you know a reason why it should and you > > explain it to me. > I encountered system lock during verifying the pm function. > Anyway, I will tested again whether it works after removing it. Re-checked the code flow, I see no reason why this isb should be there. Adding barriers changes code execution, this might paper over some issues instead of solving them, so every single barrier should be commented and added with a specific purpose that I do not see here. Lorenzo