From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932831AbbA3OZL (ORCPT ); Fri, 30 Jan 2015 09:25:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53249 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932767AbbA3OZJ (ORCPT ); Fri, 30 Jan 2015 09:25:09 -0500 Date: Fri, 30 Jan 2015 15:24:47 +0100 From: Jiri Olsa To: Steven Rostedt Cc: Wang Nan , jeremie.galarneau@efficios.com, alexmonthy@voxpopuli.im, bigeasy@linutronix.de, lizefan@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] tools lib traceevent: add priv field to struct format_field. Message-ID: <20150130142447.GA19178@krava.brq.redhat.com> References: <1422268705-32084-1-git-send-email-wangnan0@huawei.com> <1422268705-32084-2-git-send-email-wangnan0@huawei.com> <20150130091719.6464f945@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150130091719.6464f945@gandalf.local.home> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 30, 2015 at 09:17:19AM -0500, Steven Rostedt wrote: > On Mon, 26 Jan 2015 18:38:23 +0800 > Wang Nan wrote: > > > > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c > > index cf3a44b..5f76003 100644 > > --- a/tools/lib/traceevent/event-parse.c > > +++ b/tools/lib/traceevent/event-parse.c > > @@ -5909,6 +5909,8 @@ static void free_format_fields(struct format_field *field) > > free(field->type); > > free(field->name); > > free(field); > > + if (field->destroy_priv) > > + field->destroy_priv(field); > > I think you want to call field->destroy_priv() *before* you free field. argh.. missed that :-\ will fix thanks, jirka > > -- Steve > > > field = next; > > } > > }