LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Eduardo Valentin <edubezval@gmail.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: devicetree@vger.kernel.org, "Mark Rutland" <mark.rutland@arm.com>,
	"Wolfram Sang" <wsa@the-dreams.de>,
	"Takashi Iwai" <tiwai@suse.de>,
	linux-pci@vger.kernel.org,
	"Linus Walleij" <linus.walleij@linaro.org>,
	dri-devel@lists.freedesktop.org,
	"Mikko Perttunen" <mperttunen@nvidia.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	linux-i2c@vger.kernel.org, "Paul Walmsley" <pwalmsley@nvidia.com>,
	linux-pm@vger.kernel.org, "Alexandre Courbot" <gnurou@gmail.com>,
	"Terje Bergström" <tbergstrom@nvidia.com>,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	"Murali Karicheri" <m-karicheri2@ti.com>,
	"Dylan Reid" <dgreid@chromium.org>,
	linux-pwm@vger.kernel.org, "Pawel Moll" <pawel.moll@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Jingchang Lu" <jingchang.lu@freescale.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Sean Paul" <seanpaul@chromium.org>,
	linux-tegra@vger.kernel.org, "Zhang Rui" <rui.zhang@intel.com>,
	"John Crispin" <blogic@openwrt.org>,
	"Peter Hurley" <peter@hurleysoftware.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Peter De Schrijver" <pdeschrijver@nvidia.com>,
	linux-kernel@vger.kernel.org,
	"Tuomas Tynkkynen" <ttynkkynen@nvidia.com>,
	"Kumar Gala" <galak@codeaurora.org>, "Tejun Heo" <tj@kernel.org>
Subject: Re: [PATCH v2 2/3] Documentation: DT bindings: add more Tegra chip compatible strings
Date: Sat, 31 Jan 2015 15:28:27 -0400	[thread overview]
Message-ID: <20150131192826.GD17425@developer.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20150130221104.4761.4534.stgit@dusk.lan>

[-- Attachment #1: Type: text/plain, Size: 5385 bytes --]

Hey Paul!

On Fri, Jan 30, 2015 at 03:11:04PM -0700, Paul Walmsley wrote:
> Align compatible strings for several IP blocks present on Tegra chips
> with the latest doctrine from the DT maintainers:
> 
> http://marc.info/?l=devicetree&m=142255654213019&w=2
> 
> The primary objective here is to avoid checkpatch warnings, per:
> 
> http://marc.info/?l=linux-tegra&m=142201349727836&w=2
> 
> DT binding text files have been updated for the following IP blocks:
> 
> - PCIe
> - SOR
> - SoC timers
> - AHB "gizmo"
> - APB_MISC
> - pinmux control
> - UART
> - PWM
> - I2C
> - SPI
> - RTC
> - PMC
> - eFuse
> - AHCI
> - HDA
> - XUSB_PADCTRL
> - SDHCI
> - SOC_THERM
> - AHUB
> - I2S
> - EHCI
> - USB PHY
> 
> N.B. The nvidia,tegra20-timer compatible string is removed from the
> nvidia,tegra30-timer.txt documentation file because it's already
> mentioned in the nvidia,tegra20-timer.txt documentation file.
> 
> This second version takes into account the following requests from
> Rob Herring <robherring2@gmail.com>:
> 
> - Per-IP block patches have been combined into a single patch
> 
> - Explicit documentation about which compatible strings are actually
>   matched by the driver has been removed.  In its place is implicit
>   documentation that loosely follows Rob's prescribed format:
> 
>   "Must contain '"nvidia,<chip>-pcie", "nvidia,tegra20-pcie"' where
>    <chip> is tegra30, tegra132, ..." [...]  "You should attempt to
>    document known values of <chip> if you use it"
> 
> 
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: Dylan Reid <dgreid@chromium.org>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Jingchang Lu <jingchang.lu@freescale.com>
> Cc: John Crispin <blogic@openwrt.org>
> Cc: Kumar Gala <galak@codeaurora.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Mikko Perttunen <mperttunen@nvidia.com>
> Cc: Murali Karicheri <m-karicheri2@ti.com>
> Cc: Paul Walmsley <pwalmsley@nvidia.com>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Peter De Schrijver <pdeschrijver@nvidia.com>
> Cc: Peter Hurley <peter@hurleysoftware.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: "Terje Bergström" <tbergstrom@nvidia.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-i2c@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
> Cc: linux-pwm@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> ---
>  .../bindings/arm/tegra/nvidia,tegra20-ahb.txt      |    5 ++++-
>  .../bindings/arm/tegra/nvidia,tegra20-pmc.txt      |    6 +++++-
>  .../devicetree/bindings/ata/tegra-sata.txt         |    4 +++-
>  .../bindings/fuse/nvidia,tegra20-fuse.txt          |   10 +++++-----
>  .../bindings/gpu/nvidia,tegra20-host1x.txt         |    8 ++++++--
>  .../devicetree/bindings/i2c/nvidia,tegra20-i2c.txt |   10 +++++-----
>  .../bindings/misc/nvidia,tegra20-apbmisc.txt       |    9 ++++-----
>  .../bindings/mmc/nvidia,tegra20-sdhci.txt          |    6 +++++-
>  .../bindings/pci/nvidia,tegra20-pcie.txt           |    8 ++++----
>  .../bindings/pinctrl/nvidia,tegra124-pinmux.txt    |    3 ++-
>  .../pinctrl/nvidia,tegra124-xusb-padctl.txt        |    4 +++-
>  .../devicetree/bindings/pwm/nvidia,tegra20-pwm.txt |    7 ++++---
>  .../devicetree/bindings/rtc/nvidia,tegra20-rtc.txt |    4 +++-
>  .../devicetree/bindings/serial/of-serial.txt       |    5 ++++-
>  .../bindings/sound/nvidia,tegra30-ahub.txt         |    5 ++++-
>  .../bindings/sound/nvidia,tegra30-hda.txt          |    4 +++-
>  .../bindings/sound/nvidia,tegra30-i2s.txt          |    5 ++++-
>  .../bindings/spi/nvidia,tegra114-spi.txt           |    4 +++-
>  .../devicetree/bindings/thermal/tegra-soctherm.txt |    4 +++-

<cut>

> diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> index ecf3ed76cd46..6b68cd150405 100644
> --- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> +++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
> @@ -7,7 +7,9 @@ notifications. It is also used to manage emergency shutdown in an
>  overheating situation.
>  
>  Required properties :
> -- compatible : "nvidia,tegra124-soctherm".
> +- compatible : For Tegra124, must contain "nvidia,tegra124-soctherm".
> +  For Tegra132, must contain "nvidia,tegra132-soctherm".
> +  For Tegra210, must contain "nvidia,tegra210-soctherm".
>  - reg : Should contain 1 entry:
>    - SOCTHERM register set
>  - interrupts : Defines the interrupt used by SOCTHERM

Considering that this is going into a single patch, you may add my

Acked-by: Eduardo Valentin <edubezval@gmail.com>

for what concerns the thermal bindings.

Cheers,

Eduardo Valentin

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2015-01-31 19:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30 22:11 [PATCH v2 0/3] Documentation: DT bindings: update DT binding docs with Tegra chips Paul Walmsley
2015-01-30 22:11 ` [PATCH v2 3/3] Documentation: DT bindings: add nvidia, tegra132-denver compatible string Paul Walmsley
2015-01-30 22:11 ` [PATCH v2 1/3] Documentation: DT: document compatible string existence requirement Paul Walmsley
2015-01-30 22:11 ` [PATCH v2 2/3] Documentation: DT bindings: add more Tegra chip compatible strings Paul Walmsley
2015-01-31 19:28   ` Eduardo Valentin [this message]
2015-02-05 19:25   ` Wolfram Sang
2015-02-04  2:36 ` [PATCH v2 0/3] Documentation: DT bindings: update DT binding docs with Tegra chips Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150131192826.GD17425@developer.hsd1.ca.comcast.net \
    --to=edubezval@gmail.com \
    --cc=blogic@openwrt.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dgreid@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=galak@codeaurora.org \
    --cc=gnurou@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jingchang.lu@freescale.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    --cc=mark.rutland@arm.com \
    --cc=mperttunen@nvidia.com \
    --cc=paul@pwsan.com \
    --cc=pawel.moll@arm.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=peter@hurleysoftware.com \
    --cc=pwalmsley@nvidia.com \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=seanpaul@chromium.org \
    --cc=swarren@wwwdotorg.org \
    --cc=tbergstrom@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.de \
    --cc=tj@kernel.org \
    --cc=ttynkkynen@nvidia.com \
    --cc=wsa@the-dreams.de \
    --subject='Re: [PATCH v2 2/3] Documentation: DT bindings: add more Tegra chip compatible strings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).