LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Abel Moyo <abelmoyo.ab@gmail.com>,
	Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] staging: rtl8188eu: core: switch with redundant cases
Date: Wed, 4 Feb 2015 14:42:13 +0300	[thread overview]
Message-ID: <20150204114213.GA5336@mwanda> (raw)
In-Reply-To: <1423047878-5783-1-git-send-email-hofrat@osadl.org>

On Wed, Feb 04, 2015 at 06:04:38AM -0500, Nicholas Mc Guire wrote:
> A few redundant switch cases as well as a redundant if/else
> within one of the cases was consolidated to a single call.
> The cases are intentionally retained for documentation purposes.

This statement is not clear.  It obviously causes a bug if you just
start deleting case statements.

> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> case WIFI_REASSOCREQ,WIFI_PROBEREQ,WIFI_BEACON,WIFI_ACTION all
> have the same effect - notably the also for WIFI_PROBEREQ where
> the if/else is executing the same function. 
> 
> These redundant cases could all be dropped and consolidated into
> the default but probably it is better for documentation/readability
> to leave them in the switch/case explicitly.

Oh.  This explains what you meant.  Stop putting this information below
the cut off, it's annoying.

regards,
dan carpenter


  reply	other threads:[~2015-02-04 11:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 11:04 Nicholas Mc Guire
2015-02-04 11:42 ` Dan Carpenter [this message]
2015-02-04 11:43 ` Dan Carpenter
2015-02-04 13:16   ` Nicholas Mc Guire
2015-02-04 12:07 ` Rasmus Villemoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150204114213.GA5336@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=abelmoyo.ab@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hofrat@osadl.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] staging: rtl8188eu: core: switch with redundant cases' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).