From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755823AbbBDXFh (ORCPT ); Wed, 4 Feb 2015 18:05:37 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47614 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754268AbbBDXFg (ORCPT ); Wed, 4 Feb 2015 18:05:36 -0500 Date: Wed, 4 Feb 2015 15:05:34 -0800 From: Andrew Morton To: Joe Perches Cc: Rasmus Villemoes , Michal Nazarewicz , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel.h: Remove ancient __FUNCTION__ hack Message-Id: <20150204150534.6969aa4b6108950ab2154906@linux-foundation.org> In-Reply-To: <1423090157.30454.1.camel@perches.com> References: <1423043318-29910-1-git-send-email-linux@rasmusvillemoes.dk> <1423076787.16386.9.camel@perches.com> <87egq5wg5y.fsf@rasmusvillemoes.dk> <1423083786.16386.13.camel@perches.com> <87a90twd2w.fsf@rasmusvillemoes.dk> <1423087515.16386.15.camel@perches.com> <20150204143515.8bd14a53fceae8f38b0b0e8d@linux-foundation.org> <1423090157.30454.1.camel@perches.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 04 Feb 2015 14:49:17 -0800 Joe Perches wrote: > trivia about macros vs c99 predefined identifiers below: > > > diff -puN include/acpi/acoutput.h~kernelh-remove-ancient-__function__-hack-fix include/acpi/acoutput.h > [] > > @@ -240,7 +240,7 @@ > > /* > > * If ACPI_GET_FUNCTION_NAME was not defined in the compiler-dependent header, > > * define it now. This is the case where there the compiler does not support > > - * a __FUNCTION__ macro or equivalent. > > + * a __func__ macro or equivalent. > > Do these still make sense? __func__ isn't a macro. Yeah, but I was too lazy to think up more appropriate text. Hey, it's only ACPI :)