LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: mu@miroslavurbanek.com, steffen.klassert@secunet.com,
	herbert@gondor.apana.org.au, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	tc@excello.cz, jh@excello.cz, fan.du@windriver.com
Subject: Re: [PATCH] flowcache: Fix kernel panic in flow_cache_flush_task
Date: Thu, 05 Feb 2015 14:39:06 -0800 (PST)	[thread overview]
Message-ID: <20150205.143906.2233107149659287418.davem@davemloft.net> (raw)
In-Reply-To: <1423154648.31870.81.camel@edumazet-glaptop2.roam.corp.google.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 05 Feb 2015 08:44:08 -0800

> On Thu, 2015-02-05 at 16:36 +0100, Miroslav Urbanek wrote:
>> flow_cache_flush_task references a structure member flow_cache_gc_work
>> where it should reference flow_cache_flush_task instead.
>> 
>> Kernel panic occurs on kernels using IPsec during XFRM garbage
>> collection. The garbage collection interval can be shortened using the
>> following sysctl settings:
>> 
>> net.ipv4.xfrm4_gc_thresh=4
>> net.ipv6.xfrm6_gc_thresh=4
>> 
>> With the default settings, our productions servers crash approximately
>> once a week. With the settings above, they crash immediately.
>> 
>> Fixes: ca925cf1534e ("flowcache: Make flow cache name space aware")
>> Reported-by: Tomáš Charvát <tc@excello.cz>
>> Tested-by: Jan Hejl <jh@excello.cz>
>> Signed-off-by: Miroslav Urbanek <mu@miroslavurbanek.com>
>> ---
> 
> Nice catch !
> 
> Ok, but you do not need to cc so many people/lists
> 
> netdev is fine, and we usually CC patch author, just in case.
> 
> Acked-by: Eric Dumazet <edumazet@google.com>

Applied, thanks.

      reply	other threads:[~2015-02-05 22:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 15:36 Miroslav Urbanek
2015-02-05 16:44 ` Eric Dumazet
2015-02-05 22:39   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150205.143906.2233107149659287418.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=fan.du@windriver.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jh@excello.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mu@miroslavurbanek.com \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    --cc=tc@excello.cz \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH] flowcache: Fix kernel panic in flow_cache_flush_task' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).