LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Esben Haabendal <esbenhaabendal@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Esben Haabendal <esben.haabendal@gmail.com>,
	stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org, Stefan Roese <sr@denx.de>
Subject: Re: Backport of spi-fsl-spi bugfix to 3.14.y
Date: Thu, 5 Feb 2015 14:33:48 +0000	[thread overview]
Message-ID: <20150205143348.GV21293@sirena.org.uk> (raw)
In-Reply-To: <1423040613.3304.10.camel@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]

On Wed, Feb 04, 2015 at 10:03:33AM +0100, Esben Haabendal wrote:

> I suspect that the regression I have observed is caused by the
> combination of the following two commits:

> commit 059b8ffeee5b427949872bb6ed5db5ae0788054e
>   spi: make sure all transfer has proper speed set

> commit e6811d1d7a6a38ee637fe219c3b67dbfe17e8b3f
>   spi: make sure all transfer has bits_per_word set

> And the broken behaviour of the spi-fsl-spi driver prior to the (now
> backported) commit 4302a59629f7a0bd70fd1605d2b558597517372a.

> A side effect of the two above mentioned commits is that the spi all
> transfers (in multi message transfers) have their transfer speed_hz and
> bits_per_word set, which is not handled properly by spi-fsl-spi.

OK, so this is the analysis I was looking for before we merged the patch
into stable - we shouldn't normally be merging new features in so we
really need to understand why the new feature is appropriate.  "This
seems to make it work" isn't doing that.

The other problem was that I didn't know this was in stable until after
the fact - we should try to avoid that happening in future.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

      reply	other threads:[~2015-02-05 14:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-05 15:42 Esben Haabendal
2015-01-05 15:48 ` Mark Brown
2015-01-06 21:15   ` Esben Haabendal
2015-01-23 12:45     ` Mark Brown
2015-01-25 17:38       ` Greg Kroah-Hartman
2015-01-25 20:12         ` Mark Brown
2015-01-25 22:07           ` Greg Kroah-Hartman
2015-02-04  9:03             ` Esben Haabendal
2015-02-05 14:33               ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150205143348.GV21293@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=esben.haabendal@gmail.com \
    --cc=esbenhaabendal@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=sr@denx.de \
    --cc=stable@vger.kernel.org \
    --subject='Re: Backport of spi-fsl-spi bugfix to 3.14.y' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).