LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	tixy@linaro.org, Wang Nan <wangnan0@huawei.com>,
	linux@arm.linux.org.uk,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	lizefan@huawei.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -tip/urgent 1/2] [BUGFIX]kprobes: set kprobes_all_disarmed earlier to enable re-optimization.
Date: Thu, 5 Feb 2015 14:49:54 -0800	[thread overview]
Message-ID: <20150205144954.d93eda6ba8be265e23037799@linux-foundation.org> (raw)
In-Reply-To: <20150123064224.30731.30127.stgit@localhost.localdomain>

On Fri, 23 Jan 2015 15:42:24 +0900 Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:

> From: Wang Nan <wangnan0@huawei.com>
> 
> In original code, the probed instruction doesn't get optimized after
> 
> echo 0 > /sys/kernel/debug/kprobes/enabled
> echo 1 > /sys/kernel/debug/kprobes/enabled
> 
> This is because original code checks kprobes_all_disarmed in
> optimize_kprobe(), but this flag is turned off after calling that
> function. Therefore, optimize_kprobe() will see
> kprobes_all_disarmed == true and doesn't do the optimization.
> 
> This patch simply turns off kprobes_all_disarmed earlier to enable
> optimization.
> 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

You sent the patches, so this should have been "Signed-off-by:". 
Documentation/SubmittingPatches section 12 has the details.

I have made that change to my copy of these two patches.


  reply	other threads:[~2015-02-05 22:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23  6:42 [PATCH -tip/urgent 0/2]kprobes bugfixes around optprobe Masami Hiramatsu
2015-01-23  6:42 ` [PATCH -tip/urgent 1/2] [BUGFIX]kprobes: set kprobes_all_disarmed earlier to enable re-optimization Masami Hiramatsu
2015-02-05 22:49   ` Andrew Morton [this message]
2015-01-23  6:42 ` [PATCH -tip/urgent 2/2] [BUGFIX]kprobes: makes kprobes/enabled works correctly for optimized kprobes Masami Hiramatsu
2015-01-26  5:38 ` [PATCH -tip/urgent 0/2]kprobes bugfixes around optprobe Wang Nan
2015-02-04 11:01   ` Wang Nan
2015-02-05  1:59     ` Wang Nan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150205144954.d93eda6ba8be265e23037799@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=lizefan@huawei.com \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@kernel.org \
    --cc=tixy@linaro.org \
    --cc=wangnan0@huawei.com \
    --subject='Re: [PATCH -tip/urgent 1/2] [BUGFIX]kprobes: set kprobes_all_disarmed earlier to enable re-optimization.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).