LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 1/1 linux-next] udf: use bool for done
Date: Thu, 5 Feb 2015 16:36:58 +0100	[thread overview]
Message-ID: <20150205153658.GI4258@quack.suse.cz> (raw)
In-Reply-To: <1423070104-7308-1-git-send-email-fabf@skynet.be>

On Wed 04-02-15 18:15:04, Fabian Frederick wrote:
> variable 'done' is only used for true/false in loop.
  OK, looks good. Merged.

							Honza

> 
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>  fs/udf/super.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index 3d35a75..f169411 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -1599,7 +1599,7 @@ static noinline int udf_process_sequence(
>  	struct udf_vds_record *curr;
>  	struct generic_desc *gd;
>  	struct volDescPtr *vdp;
> -	int done = 0;
> +	bool done = false;
>  	uint32_t vdsn;
>  	uint16_t ident;
>  	long next_s = 0, next_e = 0;
> @@ -1680,7 +1680,7 @@ static noinline int udf_process_sequence(
>  				lastblock = next_e;
>  				next_s = next_e = 0;
>  			} else
> -				done = 1;
> +				done = true;
>  			break;
>  		}
>  		brelse(bh);
> -- 
> 1.9.3
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

      reply	other threads:[~2015-02-05 15:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 17:15 Fabian Frederick
2015-02-05 15:36 ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150205153658.GI4258@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=fabf@skynet.be \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/1 linux-next] udf: use bool for done' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).