LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 1/7] trace: fix the glob match in __unregister_ftrace_function_probe()
Date: Thu, 5 Feb 2015 17:52:44 -0500 [thread overview]
Message-ID: <20150205175244.465c629e@gandalf.local.home> (raw)
In-Reply-To: <20150205223038.GV29656@ZenIV.linux.org.uk>
On Thu, 5 Feb 2015 22:30:39 +0000
Al Viro <viro@ZenIV.linux.org.uk> wrote:
> On Thu, Feb 05, 2015 at 03:43:36PM -0500, Steven Rostedt wrote:
> > Can you make search = NULL instead of glob at the start of the
> > function. That is:
> >
> > if (!glob || strcmp(glob, "*") == 0 || !strlen(glob))
> > search = NULL;
>
> Umm... If we do it that way, I'd rather initialized search with NULL
> and inverted the test:
> if (glob && *glob && strcmp(glob, "*") != 0) {
> parse it and set search
> }
Fine with me.
-- Steve
next prev parent reply other threads:[~2015-02-05 22:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 19:49 [RFC][PATCHES] constifying ftrace globs Al Viro
2015-02-05 19:56 ` [RFC][PATCH 1/7] trace: fix the glob match in __unregister_ftrace_function_probe() Al Viro
2015-02-05 20:43 ` Steven Rostedt
2015-02-05 22:30 ` Al Viro
2015-02-05 22:52 ` Steven Rostedt [this message]
2015-02-05 19:56 ` [RFC][PATCH 2/7] implement memmem() Al Viro
2015-02-05 19:56 ` [RFC][PATCH 3/7] trace_events_filter.c: switch to memcmp() and memmem() for matching Al Viro
2015-02-05 19:56 ` [RFC][PATCH 4/7] ftrace: switch matching to memcmp() and memmem() Al Viro
2015-02-05 19:56 ` [RFC][PATCH 5/7] trace: make filter_parse_regex() provide the length of substring to compare with Al Viro
2015-02-05 21:29 ` Steven Rostedt
2015-02-05 21:44 ` Al Viro
2015-02-05 22:07 ` Steven Rostedt
2015-02-05 22:46 ` Al Viro
2015-02-06 4:00 ` [RFC][PATCH v2 1/7] trace: fix the glob match in __unregister_ftrace_function_probe() Al Viro
2015-02-06 4:00 ` [RFC][PATCH v2 2/7] implement memmem() Al Viro
2015-02-06 16:19 ` Steven Rostedt
2015-02-06 22:30 ` Rasmus Villemoes
2015-02-06 22:55 ` Steven Rostedt
2015-02-06 23:14 ` Rasmus Villemoes
2015-02-06 4:00 ` [RFC][PATCH v2 3/7] trace_events_filter.c: switch to memcmp() and memmem() for matching Al Viro
2015-02-06 16:24 ` Steven Rostedt
2015-02-06 4:00 ` [RFC][PATCH v2 4/7] ftrace: switch matching to memcmp() and memmem() Al Viro
2015-02-06 4:00 ` [RFC][PATCH v2 5/7] trace: make filter_parse_regex() provide the length of substring to compare with Al Viro
2015-02-06 18:55 ` Steven Rostedt
2015-02-06 4:00 ` [RFC][PATCH v2 6/7] trace: constify filter_parse_regex(), match_records(), ftrace_match() and ftrace_match_record() Al Viro
2015-02-06 18:56 ` Steven Rostedt
2015-02-06 4:00 ` [RFC][PATCH v2 7/7] trace: constify glob arguments all way up to ftrace_function_set_regexp() Al Viro
2015-02-05 19:56 ` [RFC][PATCH 6/7] trace: constify filter_parse_regex(), match_records(), ftrace_match() and ftrace_match_record() Al Viro
2015-02-05 21:31 ` Steven Rostedt
2015-02-05 19:56 ` [RFC][PATCH 7/7] trace: constify glob arguments all way up to ftrace_function_set_regexp() Al Viro
2020-01-24 23:45 ` [RFC][PATCHES] constifying ftrace globs Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205175244.465c629e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--subject='Re: [RFC][PATCH 1/7] trace: fix the glob match in __unregister_ftrace_function_probe()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).