LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Peter Korsgaard <jacmet@sunsite.dk>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] i2c: i2c-ocores: fix clock-frequency binding usage
Date: Thu, 5 Feb 2015 20:11:05 +0100	[thread overview]
Message-ID: <20150205191105.GA15307@katana> (raw)
In-Reply-To: <1422890893-30989-2-git-send-email-jcmvbkbc@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

On Mon, Feb 02, 2015 at 06:28:12PM +0300, Max Filippov wrote:
> clock-frequency property is meant to control the bus frequency for i2c bus
> drivers, but it was incorrectly used to specify i2c controller input clock
> frequency.
> Introduce new attribute, opencores,ip-clock-frequency, that specifies i2c
> controller clock frequency and make clock-frequency attribute compatible
> with other i2c drivers. Maintain backwards compatibility in case
> opencores,ip-clock-frequency attribute is missing.
> 
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>

Exactly what I had in mind. Thank you for making the effort to fix this
properly!

Applied to for-next!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-02-05 19:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02 15:28 [PATCH v2 0/2] i2c: i2c-ocores: clock improvements Max Filippov
2015-02-02 15:28 ` [PATCH v2 1/2] i2c: i2c-ocores: fix clock-frequency binding usage Max Filippov
2015-02-05 19:11   ` Wolfram Sang [this message]
2015-02-05 19:46     ` Max Filippov
2015-02-05 19:51       ` Wolfram Sang
2015-02-02 15:28 ` [PATCH v2 2/2] i2c: i2c-ocores: add common clock support Max Filippov
2015-02-05 19:15   ` Wolfram Sang
2015-02-05 19:24     ` Max Filippov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150205191105.GA15307@katana \
    --to=wsa@the-dreams.de \
    --cc=jacmet@sunsite.dk \
    --cc=jcmvbkbc@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v2 1/2] i2c: i2c-ocores: fix clock-frequency binding usage' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).