LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] mtd: update ops->oobretlen in concat_write_oob
@ 2015-01-20 9:35 Niklas Cassel
2015-02-06 4:33 ` Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Cassel @ 2015-01-20 9:35 UTC (permalink / raw)
To: dwmw2; +Cc: computersforpeace, linux-mtd, linux-kernel, Niklas Cassel
In concat_read_oob both retlen and oobretlen is updated.
concat_write_oob previously only updated retlen.
Signed-off-by: Niklas Cassel <niklass@axis.com>
---
drivers/mtd/mtdconcat.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/mtdconcat.c b/drivers/mtd/mtdconcat.c
index b900056..d85c946 100644
--- a/drivers/mtd/mtdconcat.c
+++ b/drivers/mtd/mtdconcat.c
@@ -311,7 +311,8 @@ concat_write_oob(struct mtd_info *mtd, loff_t to, struct mtd_oob_ops *ops)
devops.len = subdev->size - to;
err = mtd_write_oob(subdev, to, &devops);
- ops->retlen += devops.oobretlen;
+ ops->retlen += devops.retlen;
+ ops->oobretlen += devops.oobretlen;
if (err)
return err;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: update ops->oobretlen in concat_write_oob
2015-01-20 9:35 [PATCH] mtd: update ops->oobretlen in concat_write_oob Niklas Cassel
@ 2015-02-06 4:33 ` Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2015-02-06 4:33 UTC (permalink / raw)
To: Niklas Cassel; +Cc: dwmw2, linux-mtd, linux-kernel, Niklas Cassel
On Tue, Jan 20, 2015 at 10:35:32AM +0100, Niklas Cassel wrote:
> In concat_read_oob both retlen and oobretlen is updated.
> concat_write_oob previously only updated retlen.
>
> Signed-off-by: Niklas Cassel <niklass@axis.com>
Pushed to l2-mtd.git. Thanks.
Brian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-06 4:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-20 9:35 [PATCH] mtd: update ops->oobretlen in concat_write_oob Niklas Cassel
2015-02-06 4:33 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).