LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Parmeshwr Prasad <parmeshwr_prasad@dell.com>
Cc: Matt Fleming <matt@console-pimps.org>,
	Dave Young <dyoung@redhat.com>,
	Jon Masters <jonathan@jonmasters.org>,
	Laszlo Ersek <lersek@redhat.com>,
	linux-efi <linux-efi@vger.kernel.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Matt Fleming <matt.fleming@intel.com>,
	Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] efi, x86: Add a "debug" option to the efi= cmdline
Date: Fri, 6 Feb 2015 11:49:17 +0100	[thread overview]
Message-ID: <20150206104917.GB3220@pd.tnic> (raw)
In-Reply-To: <20150206060007.GA26758@linuxteamdev.amer.dell.com>

On Fri, Feb 06, 2015 at 01:00:12AM -0500, Parmeshwr Prasad wrote:
> I am really sorry that I could not mentioned for what purpose this patch is .
> I wanted this patch to be included along with your patch.  As your patch is 
> To add “debug” cmdline in efi=”<option>”.
> 
> There are some messages in efifb which appears while booting. I thought of
> Putting that messages under efi=”debug” cmdline. When efi=debug is given 
> Then only efifb messages should appear.

This is not how we do patches. If you feel that those printks in efifb
are too verbose and should be behind a debug switch or, even removed
completely, you can do a separate patch as I explained to you and write
in that commit message what needs to be done and *why* you think it
should be done.

HTH.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

  reply	other threads:[~2015-02-06 10:49 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09  9:58 Shorten efi regions output Borislav Petkov
2014-12-09 12:42 ` Ard Biesheuvel
2014-12-09 12:48   ` Borislav Petkov
2014-12-09 15:35 ` Laszlo Ersek
2014-12-09 16:45   ` Borislav Petkov
2014-12-10  2:17 ` Dave Young
2014-12-10 10:46   ` Borislav Petkov
2015-01-05 14:03     ` Matt Fleming
2015-01-05 15:00       ` Laszlo Ersek
2015-01-21  5:48         ` Jon Masters
2015-01-21 10:06           ` Borislav Petkov
2015-01-26 10:49             ` Matt Fleming
2015-01-30 16:43               ` [PATCH] efi, x86: Add a "debug" option to the efi= cmdline Borislav Petkov
2015-01-30 16:58                 ` Laszlo Ersek
2015-01-30 18:06                 ` Randy Dunlap
2015-01-30 21:17                   ` Borislav Petkov
2015-02-04 12:18                   ` Parmeshwr Prasad
2015-02-05  3:18                 ` Dave Young
2015-02-05  8:11                   ` Borislav Petkov
2015-02-05  8:41                     ` Dave Young
2015-02-05 10:44                       ` [PATCH v2] " Borislav Petkov
2015-02-05 12:45                         ` Parmeshwr Prasad
2015-02-05 14:28                           ` Borislav Petkov
2015-02-06  6:00                             ` Parmeshwr Prasad
2015-02-06 10:49                               ` Borislav Petkov [this message]
2015-02-24 22:33                         ` Matt Fleming
2015-04-02 12:27 ` [tip:core/efi] x86/efi: " tip-bot for Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150206104917.GB3220@pd.tnic \
    --to=bp@alien8.de \
    --cc=ard.biesheuvel@linaro.org \
    --cc=dyoung@redhat.com \
    --cc=jonathan@jonmasters.org \
    --cc=lersek@redhat.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=matt@console-pimps.org \
    --cc=parmeshwr_prasad@dell.com \
    --cc=ricardo.neri-calderon@linux.intel.com \
    --subject='Re: [PATCH v2] efi, x86: Add a "debug" option to the efi= cmdline' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).