LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Bob Liu <bob.liu@oracle.com>
Cc: <xen-devel@lists.xen.org>, <david.vrabel@citrix.com>,
	<linux-kernel@vger.kernel.org>, <roger.pau@citrix.com>,
	<konrad.wilk@oracle.com>, <boris.ostrovsky@oracle.com>,
	<wei.liu2@citrix.com>
Subject: Re: [PATCH 1/2] xenbus_client: extend interface to suppurt multi-page ring
Date: Fri, 6 Feb 2015 10:57:30 +0000	[thread overview]
Message-ID: <20150206105730.GB30821@zion.uk.xensource.com> (raw)
In-Reply-To: <1422008071-27643-1-git-send-email-bob.liu@oracle.com>

On Fri, Jan 23, 2015 at 06:14:30PM +0800, Bob Liu wrote:
[...]
>  	rv = xenbus_alloc_evtchn(dev, &priv->evtchn);
>  	if (rv)
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index 908e65e..8513764 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1955,7 +1955,7 @@ int xenvif_map_frontend_rings(struct xenvif_queue *queue,
>  	int err = -ENOMEM;
>  
>  	err = xenbus_map_ring_valloc(xenvif_to_xenbus_device(queue->vif),
> -				     tx_ring_ref, &addr);
> +				&tx_ring_ref, 1, &addr);
>  	if (err)
>  		goto err;
>  
> @@ -1963,7 +1963,7 @@ int xenvif_map_frontend_rings(struct xenvif_queue *queue,
>  	BACK_RING_INIT(&queue->tx, txs, PAGE_SIZE);
>  
>  	err = xenbus_map_ring_valloc(xenvif_to_xenbus_device(queue->vif),
> -				     rx_ring_ref, &addr);
> +				&rx_ring_ref, 1, &addr);

With my netback maintainer hat on, indentation here looks wrong. Not
sure if this is my fault when writing the original patch, but it would
be good if you fix them in next posting. :-)

Thanks
Wei.

      parent reply	other threads:[~2015-02-06 10:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 10:14 Bob Liu
2015-01-23 10:14 ` [PATCH 2/2] drivers: xen/block: add multi-page ring support Bob Liu
2015-02-02 10:43   ` Roger Pau Monné
2015-02-06 10:47     ` Bob Liu
2015-02-06 11:01       ` Wei Liu
2015-02-06 12:52         ` Bob Liu
2015-02-05 17:41   ` [Xen-devel] " Felipe Franciosi
2015-02-06 10:43     ` Bob Liu
2015-02-06 10:57 ` Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150206105730.GB30821@zion.uk.xensource.com \
    --to=wei.liu2@citrix.com \
    --cc=bob.liu@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --subject='Re: [PATCH 1/2] xenbus_client: extend interface to suppurt multi-page ring' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).