Re: [PATCH] Sony-laptop: fix sparse warning

[Darren Hart <dvhart@infradead.org>]

On Thu, Feb 05, 2015 at 04:00:32PM +0000, Lad, Prabhakar wrote:
> Hi Giedrius,
> 
> On Thu, Feb 5, 2015 at 3:55 PM, Giedrius Statkevičius
> <giedrius.statkevicius@gmail.com> wrote:
> > On 2015.02.05 16:49, Lad Prabhakar wrote:
> >> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> >>
> >> this patch fixes following sparse warning:
> >>
> >> sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. Should it be static?
> >>
> >> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> > Don't put a comma between your first and last name, please. Also, is
> > this your real name and surname?
> >
> I have hundreds of patches with:
> 
> Lad, Prabhakar <prabhakar.lad@ti.com>
> Lad, Prabhakar <prabhakar.csengg@gmail.com>

I think there may be a problem with this in an unquoted email address. The
unquoted local part, per RFC 2822 3.4.1, can only contain  !#$%'*+-/=?^_`{|}~
and . separators.

David Miller is the one who usually catches this sort of thing. David, do we
have a problem here?

> 
> I don’t want to change it now! Yes that's my real name.
> 
> Cheers,
> --Prabhakar
> 

-- 
Darren Hart
Intel Open Source Technology Center