LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
	"Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>,
	"Mattia Dongili" <malattia@linux.it>,
	platform-driver-x86@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	"David Miller" <davem@davemloft.net>
Subject: Re: [PATCH] Sony-laptop: fix sparse warning
Date: Sat, 7 Feb 2015 12:07:10 -0800	[thread overview]
Message-ID: <20150207200710.GA42679@vmdeb7> (raw)
In-Reply-To: <87386irm6b.fsf@nemi.mork.no>

On Sat, Feb 07, 2015 at 12:33:16PM +0100, Bjørn Mork wrote:
> Darren Hart <dvhart@infradead.org> writes:
> > On Thu, Feb 05, 2015 at 04:00:32PM +0000, Lad, Prabhakar wrote:
> >
> >> Lad, Prabhakar <prabhakar.lad@ti.com>
> >> Lad, Prabhakar <prabhakar.csengg@gmail.com>
> >
> > I think there may be a problem with this in an unquoted email address. The
> > unquoted local part, per RFC 2822 3.4.1, can only contain  !#$%'*+-/=?^_`{|}~
> > and . separators.
> 
> Yes, but that is not applicable to the git commit tags.  They are not
> RFC2822 header fields.  Nothing will ever parse "Lad" as an unqualified
> local destination in a SOB, and therefore there is no problem using the
> comma there.

Also, my reading was incorrect as "local part" refers to the text preceeding
the @ character, not the text outside the <>. So, while the name should probably
be quoted to avoid problems with MUAs interpretting the , as a list separator, I
don't have anything definitive to reference to prevent it. So at least for now,
I'll be accepting Lad's contributions as is, comma and all :-)

I really dislike this aspect of our tooling. Being so free form, it's
inevitiable for even seasoned contributors to trip over these sort of implicit
rules. It seems to me that a very significant, perhaps not the majority, of the
time I spend as maintainer is dealing with things like coding style, commit
message formatting, and similar issues. I can sympathize with those who
criticize our mechanisms as archaic :-/

> 
> Note that names using non-ascii characters are often written without
> quotes i SOBs (wonder how I know this? :-).  In practice I believe the
> character set is only limited by what you will allow in your git log.
> The only characters with a special meaning are :<>#, and the latter is
> somewhat dubious.  But it's often used as a comment separator in stable
> CCs, so I guess it should be avoided for other uses.
> 
> Scripts etc trying to parse these tags into email headers must be
> prepared to do the necessary stripping and quoting of any text outside
> the <> brackets.
> 
> Requiring a full name is of course good for accountability, but do let
> people format their names as they want them to appear in the log.
> Different cultures have different traditions. Wookey has collected a few
> links on this subject if anyone is interested:
> http://wookware.org/name.html
> 

Thanks Bjørn :-)

> 
> Bjørn
> 

-- 
Darren Hart
Intel Open Source Technology Center

  reply	other threads:[~2015-02-07 20:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 14:49 Lad Prabhakar
2015-02-05 15:55 ` Giedrius Statkevičius
2015-02-05 16:00   ` Lad, Prabhakar
2015-02-07  3:08     ` Darren Hart
2015-02-07 11:33       ` Bjørn Mork
2015-02-07 20:07         ` Darren Hart [this message]
2015-02-07 20:10 ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150207200710.GA42679@vmdeb7 \
    --to=dvhart@infradead.org \
    --cc=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=giedrius.statkevicius@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=malattia@linux.it \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    --subject='Re: [PATCH] Sony-laptop: fix sparse warning' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).