LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: "Peter Hüwe" <PeterHuewe@gmx.de>,
	"Ashley Lai" <ashley@ashleylai.com>,
	"Marcel Selhorst" <tpmdd@selhorst.net>,
	tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	josh@joshtriplett.org, christophe.ricard@gmail.com,
	jason.gunthorpe@obsidianresearch.com, linux-api@vger.kernel.org,
	trousers-tech@lists.sourceforge.net
Subject: Re: [PATCH] tpm, tpm_tis: fix TPM 2.0 probing
Date: Tue, 10 Feb 2015 14:50:37 +0200	[thread overview]
Message-ID: <20150210125037.GB4313@intel.com> (raw)
In-Reply-To: <54D9F6A0.9010905@linux.vnet.ibm.com>

On Tue, Feb 10, 2015 at 07:16:32AM -0500, Stefan Berger wrote:
> On 02/09/2015 03:39 AM, Jarkko Sakkinen wrote:
> >On Mon, Feb 09, 2015 at 12:08:46AM +0100, Peter Hüwe wrote:
> >>Am Mittwoch, 4. Februar 2015, 15:21:09 schrieb Jarkko Sakkinen:
> >>>If during transmission system error was returned, the logic was to
> >>>incorrectly deduce that chip is a TPM 1.x chip. This patch fixes this
> >>>issue. Also, this patch changes probing so that message tag is used as the
> >>>measure for TPM 2.x, which should be much more stable.
> >>Is it aware that some TPMs may respond with 0x00C1 as TAG for TPM1.2 commands?
> >I guess none of the TPM 1.2 command answer with the tag 0x8002?
> 
> 
> FYI: pdf page 26 , section 6.1 explains the predictable return value for a
> TPM1.2 command seen by a TPM2
> 
> http://www.trustedcomputinggroup.org/files/static_page_files/8C68ADA8-1A4B-B294-D0FC06D3773F7DAA/TPM%20Rev%202.0%20Part%203%20-%20Commands%2001.16-code.pdf
> 
> Following this:
> 
> Sending a TPM1.2 command to a TPM2 should return a TPM1.2 header (tag =
> 0xc4) and error code (TPM_BADTAG = 0x1e)
> 
> Sending a TPM 2 command to a TPM 2 will give a TPM 2 tag in the header.
> Sending a TPM 2 command to a TPM 1.2 will give a TPM 1.2 tag in the header
> and an error code.

Thank you for the information. Do you think that for some reason
tpm2_probe() shoould instead check that value is not this error
instead of checking that tag is 0x80002?

>    Stefan

/Jarkko

  reply	other threads:[~2015-02-10 12:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 14:21 Jarkko Sakkinen
2015-02-08 23:08 ` Peter Hüwe
2015-02-09  8:39   ` Jarkko Sakkinen
2015-02-10 12:16     ` Stefan Berger
2015-02-10 12:50       ` Jarkko Sakkinen [this message]
2015-02-11 18:47         ` Stefan Berger
2015-02-12  5:25           ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150210125037.GB4313@intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=PeterHuewe@gmx.de \
    --cc=ashley@ashleylai.com \
    --cc=christophe.ricard@gmail.com \
    --cc=jason.gunthorpe@obsidianresearch.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=tpmdd@selhorst.net \
    --cc=trousers-tech@lists.sourceforge.net \
    --subject='Re: [PATCH] tpm, tpm_tis: fix TPM 2.0 probing' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).