From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753112AbbBRVCh (ORCPT ); Wed, 18 Feb 2015 16:02:37 -0500 Received: from mail-wg0-f42.google.com ([74.125.82.42]:44064 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750985AbbBRVCe (ORCPT ); Wed, 18 Feb 2015 16:02:34 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Tony Lindgren Subject: Re: Nokia N900: omap aes is broken Date: Wed, 18 Feb 2015 22:02:30 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-45-generic; KDE/4.14.2; x86_64; ; ) Cc: Nishanth Menon , Felipe Balbi , Ivaylo Dimitrov , Aaro Koskinen , Sebastian Reichel , Pavel Machek , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-crypto@vger.kernel.org References: <201502181321.03774@pali> In-Reply-To: <201502181321.03774@pali> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart5005484.41BMGGQno3"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201502182202.30272@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart5005484.41BMGGQno3 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wednesday 18 February 2015 13:21:03 Pali Roh=C3=A1r wrote: > Hello, >=20 > I tried to test OMAP AES driver on Nokia N900 with special > Nokia bootloader which enable L3 firewall for OMAP AES HW > support. >=20 > I modified arch/arm/boot/dts/omap34xx-hs.dtsi file and > commented aes line which disable aes support in DT. >=20 > Then I booted kernel and loaded omap-aes.ko module. And I got > this output in dmesg: >=20 > [ 0.222930] platform 480c5000.aes: Cannot lookup hwmod > 'aes' [ 27.758148] omap-aes 480c5000.aes: > _od_fail_runtime_resume: FIXME: missing hwmod/omap_dev info > [ 27.765960] omap-aes 480c5000.aes: omap_aes_probe: failed > to get_sync(-19) > [ 29.257690] omap-aes 480c5000.aes: initialization failed. >=20 > So it looks like some initialization data are missing for > Nokia N900 (omap3430 device). >=20 > Can somebody look at it? I have patched 2.6.28 kernel were > omap aes support on this N900 device (with special > bootloader) is working. >=20 > Maybe some other data are missing in DT or in hwmod? dma channels are missing in DT. I applied this patch: diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index 01b7111..473d460 100644 =2D-- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -92,6 +92,8 @@ ti,hwmods =3D "aes"; reg =3D <0x480c5000 0x50>; interrupts =3D <0>; + dmas =3D <&sdma 65 &sdma 66>; + dma-names =3D "tx", "rx"; }; =20 prm: prm@48306000 { @@ -550,6 +552,8 @@ ti,hwmods =3D "sham"; reg =3D <0x480c3000 0x64>; interrupts =3D <49>; + dmas =3D <&sdma 96>; + dma-names =3D "rx"; }; =20 smartreflex_core: smartreflex@480cb000 { and omap-aes driver was successfully loaded. now it is in /proc/crypto I copied dma names and numbers from file arch/arm/mach-omap2/omap_hwmod_3xx= x_data.c =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart5005484.41BMGGQno3 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlTk/eYACgkQi/DJPQPkQ1IGewCgiKkLe134IMM6hxJcR6f0zKwA KNQAn3b1JqWcwnhDKkUVvcIYhGGUpUNF =oNe/ -----END PGP SIGNATURE----- --nextPart5005484.41BMGGQno3--