From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755209AbbBTVpo (ORCPT ); Fri, 20 Feb 2015 16:45:44 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44530 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755140AbbBTVpn (ORCPT ); Fri, 20 Feb 2015 16:45:43 -0500 Date: Fri, 20 Feb 2015 13:45:41 -0800 From: Andrew Morton To: Konstantin Khlebnikov Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: hide per-cpu lists in output of show_mem() Message-Id: <20150220134541.772f0c302a50f115b280917f@linux-foundation.org> In-Reply-To: <20150220143942.19568.4548.stgit@buzz> References: <20150220143942.19568.4548.stgit@buzz> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Feb 2015 17:39:42 +0300 Konstantin Khlebnikov wrote: > This makes show_mem() much less verbose at huge machines. Instead of > huge and almost useless dump of counters for each per-zone per-cpu > lists this patch prints sum of these counters for each zone (free_pcp) > and size of per-cpu list for current cpu (local_pcp). > > Flag SHOW_MEM_PERCPU_LISTS reverts old verbose mode. Forgot to update the comment: --- a/mm/page_alloc.c~mm-hide-per-cpu-lists-in-output-of-show_mem-fix +++ a/mm/page_alloc.c @@ -3243,8 +3243,11 @@ static void show_migration_types(unsigne * Show free area list (used inside shift_scroll-lock stuff) * We also calculate the percentage fragmentation. We do this by counting the * memory on each free list with the exception of the first item on the list. - * Suppresses nodes that are not allowed by current's cpuset if - * SHOW_MEM_FILTER_NODES is passed. + * + * Bits in @filter: + * SHOW_MEM_FILTER_NODES: suppress nodes that are not allowed by current's + * cpuset. + * SHOW_MEM_PERCPU_LISTS: display full per-node per-cpu pcp lists */ void show_free_areas(unsigned int filter) { Is there really any point in having SHOW_MEM_PERCPU_LISTS? There isn't presently a way of setting it(?).