LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Barry Song <Baohua.Song@csr.com>,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Marek Vasut <marex@denx.de>, Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH] spi: sirf: add reset controller dependency
Date: Sat, 21 Feb 2015 18:44:58 +0900	[thread overview]
Message-ID: <20150221094458.GM6236@finisterre.sirena.org.uk> (raw)
In-Reply-To: <7767301.zaEX63gvjp@wuerfel>

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

On Thu, Feb 19, 2015 at 04:01:29PM +0100, Arnd Bergmann wrote:

> So the stubs are provided for all functions except device_reset() and
> reset_control_get(), and drivers using the API need to either call the
> stubbed-out _optional() versions of these functions or have the explicit
> dependency.

In that case a dependency seems wrong, I'd expect to see a select - it's
a bit obscure to have to grovel around to figure out what magic options
are needed to make things turn on and resets feel more like a utility
thing than a control bus (which tend to be the things we depend on).
Dunno, perhaps I'm wrong?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2015-02-21  9:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 15:29 Arnd Bergmann
2015-02-19  9:41 ` Mark Brown
2015-02-19 15:01   ` Arnd Bergmann
2015-02-21  9:44     ` Mark Brown [this message]
2015-02-23 22:01       ` Arnd Bergmann
2015-02-24  7:50         ` Mark Brown
2015-02-24 10:27           ` Arnd Bergmann
2015-02-24 10:56             ` Chen-Yu Tsai
2015-02-24 13:34               ` Arnd Bergmann
2015-02-24 13:36                 ` Chen-Yu Tsai
2015-02-24 13:02           ` Arnd Bergmann
2015-02-24 14:27             ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150221094458.GM6236@finisterre.sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Baohua.Song@csr.com \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=maxime.ripard@free-electrons.com \
    --cc=p.zabel@pengutronix.de \
    --cc=wsa@the-dreams.de \
    --subject='Re: [PATCH] spi: sirf: add reset controller dependency' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).