LKML Archive on
help / color / mirror / Atom feed
From: Mark Brown <>
To: Arnd Bergmann <>
	Barry Song <>,,,
	Philipp Zabel <>,
	Maxime Ripard <>,
	Marek Vasut <>, Wolfram Sang <>
Subject: Re: [PATCH] spi: sirf: add reset controller dependency
Date: Tue, 24 Feb 2015 16:50:18 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <6170208.Z0Upu48JrX@wuerfel>

[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]

On Mon, Feb 23, 2015 at 11:01:18PM +0100, Arnd Bergmann wrote:
> On Saturday 21 February 2015 18:44:58 Mark Brown wrote:

> > In that case a dependency seems wrong, I'd expect to see a select - it's
> > a bit obscure to have to grovel around to figure out what magic options
> > are needed to make things turn on and resets feel more like a utility
> > thing than a control bus (which tend to be the things we depend on).
> > Dunno, perhaps I'm wrong?

> Mixing 'select' and 'depends on' causes recursive dependencies, and
> there are already lots of drivers that do 'depends on RESET_CONTROLLER'.

Well, perhaps that's the cleanup we should be doing then...  one of the
big problems with some of the other randconfig work there's been is that
a lot of the patches just add dependencies without looking at if that
makes sense.

> Most users of this symbol seem to follow the strategy of selecting
> RESET_CONTROLLER when a driver is there to provide the functionality,
> but depending on it when a driver uses it. We are however a bit
> inconsistent here and it would be nice to clean it up.

Right, to me that feels the opposite way round to how we normally do
things - the drivers for the subsystem normally depend on the subsystem
(or are hidden by it).

> In this particular patch, I'm just following what others do.

> We should probably 'select ARCH_HAS_RESET_CONTROLLER' unconditionally
> for ARM ARCH_MULTIPLATFORM, as it's a bit silly to select both

That does seem a bit odd.  TBH I'm never sure that ARCH_HAS_ is that
good an idea for the driver things, most of them can just as reasonably
be used by off-SoC things.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2015-02-24  7:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 15:29 Arnd Bergmann
2015-02-19  9:41 ` Mark Brown
2015-02-19 15:01   ` Arnd Bergmann
2015-02-21  9:44     ` Mark Brown
2015-02-23 22:01       ` Arnd Bergmann
2015-02-24  7:50         ` Mark Brown [this message]
2015-02-24 10:27           ` Arnd Bergmann
2015-02-24 10:56             ` Chen-Yu Tsai
2015-02-24 13:34               ` Arnd Bergmann
2015-02-24 13:36                 ` Chen-Yu Tsai
2015-02-24 13:02           ` Arnd Bergmann
2015-02-24 14:27             ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] spi: sirf: add reset controller dependency' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).