From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753384AbbBXSAZ (ORCPT ); Tue, 24 Feb 2015 13:00:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39944 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752445AbbBXSAY (ORCPT ); Tue, 24 Feb 2015 13:00:24 -0500 Date: Tue, 24 Feb 2015 17:59:50 +0000 From: "Richard W.M. Jones" To: Kyle McMartin Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: annotate psci invoke functions as notrace Message-ID: <20150224175950.GA28145@redhat.com> References: <20150218172638.GB1772@redacted.bos.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150218172638.GB1772@redacted.bos.redhat.com> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 18, 2015 at 12:26:38PM -0500, Kyle McMartin wrote: > Using GCC 5 to build the kernel with ftrace enabled, we encounter the > following error as a result of the mcount prologue changing the expected > register use of the function parameters, > > /tmp/cc8Kpn7A.s: Assembler messages: > /tmp/cc8Kpn7A.s:41: Error: .err encountered > /tmp/cc8Kpn7A.s:42: Error: .err encountered > /tmp/cc8Kpn7A.s:43: Error: .err encountered > /tmp/cc8Kpn7A.s:101: Error: .err encountered > /tmp/cc8Kpn7A.s:102: Error: .err encountered > /tmp/cc8Kpn7A.s:103: Error: .err encountered > scripts/Makefile.build:257: recipe for target 'arch/arm64/kernel/psci.o' failed > > Fix this by annotating the function as notrace, to suppress the > generation of profiling prologues and epilogues on the function. > > Signed-off-by: Kyle McMartin > > --- a/arch/arm64/kernel/psci.c > +++ b/arch/arm64/kernel/psci.c > @@ -113,7 +113,7 @@ static void psci_power_state_unpack(u32 power_state, > * The following two functions are invoked via the invoke_psci_fn pointer > * and will not be inlined, allowing us to piggyback on the AAPCS. > */ > -static noinline int __invoke_psci_fn_hvc(u64 function_id, u64 arg0, u64 arg1, > +static noinline notrace int __invoke_psci_fn_hvc(u64 function_id, u64 arg0, u64 arg1, > u64 arg2) > { > asm volatile( > @@ -128,7 +128,7 @@ static noinline int __invoke_psci_fn_hvc(u64 function_id, u64 arg0, u64 arg1, > return function_id; > } > > -static noinline int __invoke_psci_fn_smc(u64 function_id, u64 arg0, u64 arg1, > +static noinline notrace int __invoke_psci_fn_smc(u64 function_id, u64 arg0, u64 arg1, > u64 arg2) > { > asm volatile( I need this patch in order to compile the upstream kernel on aarch64 using gcc 5. Can it not be added temporarily while the longer term fix, whatever that is, is worked out? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW