LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ARM: dts: OMAP3-N900: Fix offset for smc91x ethernet
@ 2015-02-19 16:49 Pali Rohár
  2015-02-20  9:24 ` Arnd Bergmann
  0 siblings, 1 reply; 5+ messages in thread
From: Pali Rohár @ 2015-02-19 16:49 UTC (permalink / raw)
  To: Benoît Cousson, Tony Lindgren, Rob Herring
  Cc: linux-omap, devicetree, linux-kernel, Pali Rohár

Offset for smc91x must be zero otherwise smc91x linux kernel driver does not
detect smc91x ethernet hardware in qemu N900 machine.

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
 arch/arm/boot/dts/omap3-n900.dts |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index ff36fbe..b9c1c62 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -770,7 +770,7 @@
 		compatible = "smsc,lan91c94";
 		interrupt-parent = <&gpio2>;
 		interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;	/* gpio54 */
-		reg = <1 0x300 0xf>;		/* 16 byte IO range at offset 0x300 */
+		reg = <1 0x0 0xf>;		/* 16 byte IO range */
 		bank-width = <2>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&ethernet_pins>;
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: OMAP3-N900: Fix offset for smc91x ethernet
  2015-02-19 16:49 [PATCH] ARM: dts: OMAP3-N900: Fix offset for smc91x ethernet Pali Rohár
@ 2015-02-20  9:24 ` Arnd Bergmann
  2015-02-20  9:52   ` Pali Rohár
  0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2015-02-20  9:24 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Benoît Cousson, Tony Lindgren, Rob Herring, linux-omap,
	devicetree, linux-kernel

On Thursday 19 February 2015 17:49:50 Pali Rohár wrote:
> Offset for smc91x must be zero otherwise smc91x linux kernel driver does not
> detect smc91x ethernet hardware in qemu N900 machine.
> 
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> 

Is that the same offset on real hardware, or could this be a mistake in the
qemu model?

	Arnd

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: OMAP3-N900: Fix offset for smc91x ethernet
  2015-02-20  9:24 ` Arnd Bergmann
@ 2015-02-20  9:52   ` Pali Rohár
  2015-02-20 15:28     ` Tony Lindgren
  0 siblings, 1 reply; 5+ messages in thread
From: Pali Rohár @ 2015-02-20  9:52 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Benoît Cousson, Tony Lindgren, Rob Herring, linux-omap,
	devicetree, linux-kernel

[-- Attachment #1: Type: Text/Plain, Size: 977 bytes --]

On Friday 20 February 2015 10:24:35 Arnd Bergmann wrote:
> On Thursday 19 February 2015 17:49:50 Pali Rohár wrote:
> > Offset for smc91x must be zero otherwise smc91x linux kernel
> > driver does not detect smc91x ethernet hardware in qemu
> > N900 machine.
> > 
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> 
> Is that the same offset on real hardware, or could this be a
> mistake in the qemu model?
> 
> 	Arnd

In original Nokia 2.6.28 kernel is offset also set to 0, see:

https://gitorious.org/linux-n900/linux-n900/source/629fc5ab00cafb31272c478efa2c2b35fabd4c70:arch/arm/mach-omap2/board-rx51-peripherals.c#L42

https://gitorious.org/linux-n900/linux-n900/source/629fc5ab00cafb31272c478efa2c2b35fabd4c70:arch/arm/mach-omap2/board-rx51-peripherals.c#L274

Tony already tested offset 0 on real HW and wrote that it is
working too, just show some warning. But qemu with offset 0x300
does not work.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: OMAP3-N900: Fix offset for smc91x ethernet
  2015-02-20  9:52   ` Pali Rohár
@ 2015-02-20 15:28     ` Tony Lindgren
  2015-02-24 18:02       ` Tony Lindgren
  0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2015-02-20 15:28 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Arnd Bergmann, Benoît Cousson, Rob Herring, linux-omap,
	devicetree, linux-kernel

* Pali Rohár <pali.rohar@gmail.com> [150220 01:56]:
> On Friday 20 February 2015 10:24:35 Arnd Bergmann wrote:
> > On Thursday 19 February 2015 17:49:50 Pali Rohár wrote:
> > > Offset for smc91x must be zero otherwise smc91x linux kernel
> > > driver does not detect smc91x ethernet hardware in qemu
> > > N900 machine.
> > > 
> > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > 
> > Is that the same offset on real hardware, or could this be a
> > mistake in the qemu model?
> > 
> > 	Arnd
> 
> In original Nokia 2.6.28 kernel is offset also set to 0, see:
> 
> https://gitorious.org/linux-n900/linux-n900/source/629fc5ab00cafb31272c478efa2c2b35fabd4c70:arch/arm/mach-omap2/board-rx51-peripherals.c#L42
> 
> https://gitorious.org/linux-n900/linux-n900/source/629fc5ab00cafb31272c478efa2c2b35fabd4c70:arch/arm/mach-omap2/board-rx51-peripherals.c#L274
> 
> Tony already tested offset 0 on real HW and wrote that it is
> working too, just show some warning. But qemu with offset 0x300
> does not work.

Yes it works with offset 0, except the smc91x warns about not
using the default offset 0x300 based on the EEPROM. As only
three address lines seem to be connected, we can use offset
0 just fine, and update the EEPROM configuration as needed.

Regards,

Tony

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: OMAP3-N900: Fix offset for smc91x ethernet
  2015-02-20 15:28     ` Tony Lindgren
@ 2015-02-24 18:02       ` Tony Lindgren
  0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2015-02-24 18:02 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Arnd Bergmann, Benoît Cousson, Rob Herring, linux-omap,
	devicetree, linux-kernel

* Tony Lindgren <tony@atomide.com> [150220 07:47]:
> * Pali Rohár <pali.rohar@gmail.com> [150220 01:56]:
> > On Friday 20 February 2015 10:24:35 Arnd Bergmann wrote:
> > > On Thursday 19 February 2015 17:49:50 Pali Rohár wrote:
> > > > Offset for smc91x must be zero otherwise smc91x linux kernel
> > > > driver does not detect smc91x ethernet hardware in qemu
> > > > N900 machine.
> > > > 
> > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > 
> > > Is that the same offset on real hardware, or could this be a
> > > mistake in the qemu model?
> > > 
> > > 	Arnd
> > 
> > In original Nokia 2.6.28 kernel is offset also set to 0, see:
> > 
> > https://gitorious.org/linux-n900/linux-n900/source/629fc5ab00cafb31272c478efa2c2b35fabd4c70:arch/arm/mach-omap2/board-rx51-peripherals.c#L42
> > 
> > https://gitorious.org/linux-n900/linux-n900/source/629fc5ab00cafb31272c478efa2c2b35fabd4c70:arch/arm/mach-omap2/board-rx51-peripherals.c#L274
> > 
> > Tony already tested offset 0 on real HW and wrote that it is
> > working too, just show some warning. But qemu with offset 0x300
> > does not work.
> 
> Yes it works with offset 0, except the smc91x warns about not
> using the default offset 0x300 based on the EEPROM. As only
> three address lines seem to be connected, we can use offset
> 0 just fine, and update the EEPROM configuration as needed.

Applying into omap-for-v4.0/fixes with updated comments.

Regards,

Tony

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-02-24 18:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-19 16:49 [PATCH] ARM: dts: OMAP3-N900: Fix offset for smc91x ethernet Pali Rohár
2015-02-20  9:24 ` Arnd Bergmann
2015-02-20  9:52   ` Pali Rohár
2015-02-20 15:28     ` Tony Lindgren
2015-02-24 18:02       ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).