From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753032AbbBYJuP (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 Feb 2015 04:50:15 -0500
Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:43339 "EHLO
	atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752851AbbBYJuI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 Feb 2015 04:50:08 -0500
Date: Wed, 25 Feb 2015 10:50:00 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: Pali =?iso-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>,
        Nishanth Menon <nm@ti.com>, Felipe Balbi <balbi@ti.com>,
        Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
        Aaro Koskinen <aaro.koskinen@iki.fi>,
        Sebastian Reichel <sre@kernel.org>, linux-kernel@vger.kernel.org,
        linux-omap@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: Nokia N900: omap aes is broken
Message-ID: <20150225095000.GB24627@amd>
References: <201502181321.03774@pali>
 <201502182227.55488@pali>
 <20150224172512.GC28244@atomide.com>
 <201502241838.44317@pali>
 <20150224173734.GD28244@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20150224173734.GD28244@atomide.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue 2015-02-24 09:37:34, Tony Lindgren wrote:
> * Pali Rohár <pali.rohar@gmail.com> [150224 09:42]:
> > On Tuesday 24 February 2015 18:25:12 Tony Lindgren wrote:
> > > * Pali Rohár <pali.rohar@gmail.com> [150218 16:03]:
> > > > --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> > > > +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> > > > @@ -3938,8 +3938,9 @@ int __init omap3xxx_hwmod_init(void)
> > > > 
> > > >  	if (r < 0)
> > > >  	
> > > >  		return r;
> > > > 
> > > > -	/* Register GP-only hwmod links. */
> > > > -	if (h_gp && omap_type() == OMAP2_DEVICE_TYPE_GP) {
> > > > +//	/* Register GP-only hwmod links. */
> > > > +//	if (h_gp && omap_type() == OMAP2_DEVICE_TYPE_GP) {
> > > > +	if (h_gp) {
> > > > 
> > > >  		r = omap_hwmod_register_links(h_gp);
> > > >  		if (r < 0)
> > > >  		
> > > >  			return r;
> > > > 
> > > > aes hwmod is defined in GP-only hwmod...
> > > 
> > > Doesn't this depend on the bootloader version of n900 to work?
> > > 
> > > Regards,
> > > 
> > > Tony
> > 
> > Ok, it looks like second patch (omap_hwmod_3xxx_data.c) needs 
> > that aes-enabled bootloader.
> 
> OK we need some runtime detection somehow for what's enabled..
>  
> > But first patch (omap3.dtsi) is needed for proper definitions. 
> > Otherwise omap-aes driver will never work on DT systems.
> 
> Yeah that one makes sense to me, I guess you'll do a proper
> fix for that one.

If this depends on bootloader... would command line parameter be right
solution here?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html