LKML Archive on
help / color / mirror / Atom feed
From: Michal Hocko <>
To: Johannes Weiner <>
Cc: Andrew Morton <>,
	David Rientjes <>,
	"\\\"Rafael J. Wysocki\\\"" <>,
	Tetsuo Handa <>,, LKML <>
Subject: Re: [PATCH] mm, oom: do not fail __GFP_NOFAIL allocation if oom killer is disbaled
Date: Wed, 25 Feb 2015 15:02:31 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue 24-02-15 14:11:27, Johannes Weiner wrote:
> I'm fine with keeping the allocation looping, but is that message
> helpful?  It seems completely useless to the user encountering it.  Is
> it going to help kernel developers when we get a bug report with it?

It is better than a silent endless loop. And we get a trace which points
to the place which is doing the allocation. We haven't seen any weird
crashes during suspend throughout last 6 years so this would be
extremely unlikely and hard to reproduce so having the trace sounds
useful to me.


I do not expect this will spew a lot of messages. But I can live with
WARN_ON_ONCE as well.
Michal Hocko

      parent reply	other threads:[~2015-02-25 14:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 18:19 Michal Hocko
2015-02-24 18:22 ` Michal Hocko
2015-02-24 19:11 ` Johannes Weiner
2015-02-24 20:23   ` David Rientjes
2015-02-25 14:08     ` [PATCH -v2] " Michal Hocko
2015-02-25 20:41       ` David Rientjes
2015-02-26 17:34         ` Michal Hocko
2015-02-24 22:09   ` [PATCH] " Konstantin Khlebnikov
2015-02-24 22:16     ` Konstantin Khlebnikov
2015-02-25 14:02   ` Michal Hocko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] mm, oom: do not fail __GFP_NOFAIL allocation if oom killer is disbaled' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).