LKML Archive on
help / color / mirror / Atom feed
From: Richard Cochran <>
To: Stathis Voukelatos <>
Subject: Re: [PATCH net-next v4 0/3] Linn Ethernet Packet Sniffer driver
Date: Wed, 25 Feb 2015 18:30:53 +0100	[thread overview]
Message-ID: <20150225173053.GE7703@localhost.localdomain> (raw)
In-Reply-To: <>

On Wed, Feb 25, 2015 at 05:12:08PM +0000, Stathis Voukelatos wrote:
> Regarding this last point, the actual counter that generates the
> timestamps is not part of the sniffer H/W module. Timestamps are
> provided to the sniffer externally in H/W by a different module.
> Apart of that there is not eg. a sniffer register to read the
> current counter value. I wonder if it should be the driver for the
> module where the counter belongs (called Event Timer in the
> Pistachio Soc) that should register the PHC.

It is okay to have the PHC come from another driver.  However, you do
need to export PHC index to the time stamping code, in order to
provide the 'phc_index' field for the ETHTOOL_GET_TS_INFO request.

You can also have one SW driver cover both HW modules, if that is
cleaner and easier.  Among all the other drivers, only gianfar has the
PHC separate.

> I need some more time to study your other suggestions regarding the
> PHY timestamping framework.

>From my (limited) understanding of your HW device, I should think that
it will work.  The PHY time stamping subsystem is not the most obvious
code in the world.  Please feel free to ask if you have any questions.


  reply	other threads:[~2015-02-25 17:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 16:48 Stathis Voukelatos
2015-02-24 16:48 ` [PATCH net-next v4 1/3] Linn Ethernet packet sniffer: device tree binding and vendor prefix Stathis Voukelatos
2015-02-24 16:48 ` [PATCH net-next v4 2/3] Linn packet sniffer core framework Stathis Voukelatos
2015-02-24 16:48 ` [PATCH net-next v4 3/3] Linn Ethernet packet sniffer driver Stathis Voukelatos
2015-02-25 15:19 ` [PATCH net-next v4 0/3] Linn Ethernet Packet Sniffer driver Richard Cochran
2015-02-25 17:01   ` Richard Cochran
2015-02-25 17:12     ` Stathis Voukelatos
2015-02-25 17:30       ` Richard Cochran [this message]
2015-02-27 17:22         ` Stathis Voukelatos
     [not found]         ` <>
2015-02-27 18:14           ` Richard Cochran
2015-03-06 13:45             ` Stathis Voukelatos
2015-03-06 15:24               ` Richard Cochran
     [not found]             ` <>
2015-03-06 15:22               ` Richard Cochran
2015-03-11 11:20                 ` Stathis Voukelatos
2015-03-11 15:03                   ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150225173053.GE7703@localhost.localdomain \ \ \ \ \ \
    --subject='Re: [PATCH net-next v4 0/3] Linn Ethernet Packet Sniffer driver' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).