LKML Archive on
help / color / mirror / Atom feed
From: David Weinehall <>
Cc: "Imre Deak" <>, "Bjørn Mork" <>,,,, "Daniel Vetter" <>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix failure to power off after hibernate
Date: Fri, 27 Feb 2015 14:15:04 +0200	[thread overview]
Message-ID: <20150227121504.GA30560@boom> (raw)
In-Reply-To: <20150226200127.GU24485@phenom.ffwll.local>

On Thu, Feb 26, 2015 at 09:01:27PM +0100, Daniel Vetter wrote:
> On Thu, Feb 26, 2015 at 08:50:48PM +0200, Imre Deak wrote:

> > 
> > The problem seems to be that after the kernel puts the device into D3
> > the BIOS still tries to access it, or otherwise assumes that it's in D0.
> > This is clearly bogus, since ACPI mandates that devices are put into D3
> > by the OSPM if they are not wake-up sources. In the future we want to
> > unify more of the driver's runtime and system suspend paths, for example
> > by skipping all the system suspend/hibernation hooks if the device is
> > runtime suspended already. Accordingly for all other platforms the goal
> > is still to properly power down the device during hibernation.

> If we see more of these troublesome machines we might need to apply an
> even bigger hammer like gen < 5 or so. But as long as there's just 1
> report I think this is the right approach.
> Bjorn, as soon as we have your tested-by that this work we can apply this
> and shovel it through the backporting machinery.

Isn't there a risk that this will negatively impact machines using gen4
that *don't* have a buggy BIOS?  Wouldn't a quirk tied to the laptop
or BIOS version be better suited -- or possibly a parameter that can be
passed to the driver, which would make it easier to test if others
suffering from similar symptoms on other systems suffer from the same
issue or not?

Just my 2¢.

Kind regards, David Weinehall

  reply	other threads:[~2015-02-27 12:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 14:49 [BISECTED REGRESSION v3.18->v3.19-rc1] drm/i915: failure to poweroff after hibernation Bjørn Mork
2015-02-24 14:58 ` [PATCH] drm/i915: fix failure to power off after hibernate Bjørn Mork
2015-02-24 16:12   ` Imre Deak
2015-02-24 19:00     ` Bjørn Mork
2015-02-25 18:33       ` Imre Deak
2015-02-26  9:34         ` Bjørn Mork
2015-02-26 18:50           ` Imre Deak
2015-02-26 19:20             ` Bjørn Mork
2015-02-26 20:01             ` [Intel-gfx] " Daniel Vetter
2015-02-27 12:15               ` David Weinehall [this message]
2015-02-27 18:23                 ` Imre Deak
2015-03-02  8:55                   ` David Weinehall
2015-02-26 20:05             ` Ville Syrjälä
2015-02-26 20:29               ` Bjørn Mork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150227121504.GA30560@boom \ \ \ \ \ \ \ \ \
    --subject='Re: [Intel-gfx] [PATCH] drm/i915: fix failure to power off after hibernate' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).