LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: Felipe Balbi <balbi@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mark Brown <broonie@kernel.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH 4/5] usb: phy: phy-msm-usb: Rename regulator_set_optimum_mode
Date: Fri, 27 Feb 2015 09:30:05 -0600	[thread overview]
Message-ID: <20150227153005.GC22183@saruman.tx.rr.com> (raw)
In-Reply-To: <1423712131-23795-5-git-send-email-bjorn.andersson@sonymobile.com>

[-- Attachment #1: Type: text/plain, Size: 1895 bytes --]

On Wed, Feb 11, 2015 at 07:35:30PM -0800, Bjorn Andersson wrote:
> The function regulator_set_optimum_mode() is changing name to
> regulator_set_load(), so update the code accordingly.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>

since this depends on the rest of the series:

Acked-by: Felipe Balbi <balbi@ti.com>

> ---
>  drivers/usb/phy/phy-msm-usb.c | 15 +++++----------
>  1 file changed, 5 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> index 000fd89..6ed67ea 100644
> --- a/drivers/usb/phy/phy-msm-usb.c
> +++ b/drivers/usb/phy/phy-msm-usb.c
> @@ -142,27 +142,22 @@ static int msm_hsusb_ldo_set_mode(struct msm_otg *motg, int on)
>  	int ret = 0;
>  
>  	if (on) {
> -		ret = regulator_set_optimum_mode(motg->v1p8,
> -				USB_PHY_1P8_HPM_LOAD);
> +		ret = regulator_set_load(motg->v1p8, USB_PHY_1P8_HPM_LOAD);
>  		if (ret < 0) {
>  			pr_err("Could not set HPM for v1p8\n");
>  			return ret;
>  		}
> -		ret = regulator_set_optimum_mode(motg->v3p3,
> -				USB_PHY_3P3_HPM_LOAD);
> +		ret = regulator_set_load(motg->v3p3, USB_PHY_3P3_HPM_LOAD);
>  		if (ret < 0) {
>  			pr_err("Could not set HPM for v3p3\n");
> -			regulator_set_optimum_mode(motg->v1p8,
> -				USB_PHY_1P8_LPM_LOAD);
> +			regulator_set_load(motg->v1p8, USB_PHY_1P8_LPM_LOAD);
>  			return ret;
>  		}
>  	} else {
> -		ret = regulator_set_optimum_mode(motg->v1p8,
> -				USB_PHY_1P8_LPM_LOAD);
> +		ret = regulator_set_load(motg->v1p8, USB_PHY_1P8_LPM_LOAD);
>  		if (ret < 0)
>  			pr_err("Could not set LPM for v1p8\n");
> -		ret = regulator_set_optimum_mode(motg->v3p3,
> -				USB_PHY_3P3_LPM_LOAD);
> +		ret = regulator_set_load(motg->v3p3, USB_PHY_3P3_LPM_LOAD);
>  		if (ret < 0)
>  			pr_err("Could not set LPM for v3p3\n");
>  	}
> -- 
> 1.8.2.2
> 

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-02-27 15:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12  3:35 [PATCH 0/5] " Bjorn Andersson
2015-02-12  3:35 ` [PATCH 1/5] regulator: " Bjorn Andersson
2015-02-12  3:35 ` [PATCH 2/5] ufs: Rename of regulator_set_optimum_mode Bjorn Andersson
2015-04-14 12:11   ` Akinobu Mita
2015-04-15 18:35     ` Bjorn Andersson
2015-02-12  3:35 ` [PATCH 3/5] usb: phy: ab8500-usb: Rename regulator_set_optimum_mode Bjorn Andersson
2015-02-27 15:29   ` Felipe Balbi
2015-02-12  3:35 ` [PATCH 4/5] usb: phy: phy-msm-usb: " Bjorn Andersson
2015-02-27 15:30   ` Felipe Balbi [this message]
2015-02-12  3:35 ` [PATCH 5/5] regulator: Drop temporary regulator_set_optimum_mode wrapper Bjorn Andersson
2015-02-25 23:40 ` [PATCH 0/5] Rename regulator_set_optimum_mode Bjorn Andersson
2015-03-05 10:46   ` Mark Brown
2015-03-09 18:33 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150227153005.GC22183@saruman.tx.rr.com \
    --to=balbi@ti.com \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --subject='Re: [PATCH 4/5] usb: phy: phy-msm-usb: Rename regulator_set_optimum_mode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).