LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Stathis Voukelatos <stathis.voukelatos@linn.co.uk>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v4 0/3] Linn Ethernet Packet Sniffer driver
Date: Fri, 27 Feb 2015 19:14:47 +0100	[thread overview]
Message-ID: <20150227181447.GA11594@localhost.localdomain> (raw)
In-Reply-To: <54F0A4C4.3020407@linn.co.uk>

On Fri, Feb 27, 2015 at 05:09:24PM +0000, Stathis Voukelatos wrote:
> To summarize (and confirm my understanding) your suggestion is for the
> sniffer to be configured to match PTP packets and (similarly to the
> dp83640) return the Message Type and Sequence Id fields that will allow
> them to be matched to an sk_buf that has been passed from the stack.
> Then the sk_buf can be timestamped using the sniffer timestamp.

Yes.
 
> The H/W does have the capability to do that. However, in order to
> implement it there will be some architectural changes needed
> in the kernel. This module cannot really pretend to be a PHY.
> In the real world it sits between the MAC and the PHY.

Right.

Here is one idea.  Put a link to the TS device in the PHY's DT node.
Then, in phy_probe, check if the PHY's four methods, ts_info,
hwtstamp, rxtstamp, and txtstamp, are all null.  If so, check for a DT
link from the PHY's node to a TS device driver.  If found, then set
the four methods to call into the TS driver's callbacks.

Just off of the top of my head.

Thanks,
Richard

  parent reply	other threads:[~2015-02-27 18:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 16:48 Stathis Voukelatos
2015-02-24 16:48 ` [PATCH net-next v4 1/3] Linn Ethernet packet sniffer: device tree binding and vendor prefix Stathis Voukelatos
2015-02-24 16:48 ` [PATCH net-next v4 2/3] Linn packet sniffer core framework Stathis Voukelatos
2015-02-24 16:48 ` [PATCH net-next v4 3/3] Linn Ethernet packet sniffer driver Stathis Voukelatos
2015-02-25 15:19 ` [PATCH net-next v4 0/3] Linn Ethernet Packet Sniffer driver Richard Cochran
2015-02-25 17:01   ` Richard Cochran
2015-02-25 17:12     ` Stathis Voukelatos
2015-02-25 17:30       ` Richard Cochran
2015-02-27 17:22         ` Stathis Voukelatos
     [not found]         ` <54F0A4C4.3020407@linn.co.uk>
2015-02-27 18:14           ` Richard Cochran [this message]
2015-03-06 13:45             ` Stathis Voukelatos
2015-03-06 15:24               ` Richard Cochran
     [not found]             ` <54F98660.5070805@linn.co.uk>
2015-03-06 15:22               ` Richard Cochran
2015-03-11 11:20                 ` Stathis Voukelatos
2015-03-11 15:03                   ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150227181447.GA11594@localhost.localdomain \
    --to=richardcochran@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stathis.voukelatos@linn.co.uk \
    --subject='Re: [PATCH net-next v4 0/3] Linn Ethernet Packet Sniffer driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).