LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: "hpa@zytor.com" <hpa@zytor.com>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	"acme@redhat.com" <acme@redhat.com>,
	"a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"xiakaixu@huawei.com" <xiakaixu@huawei.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"linux-tip-commits@vger.kernel.org" 
	<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:perf/core] Revert "perf: Remove the extra validity check on nr_pages"
Date: Wed, 4 Mar 2015 05:46:54 +0100	[thread overview]
Message-ID: <20150304044654.GA5061@gmail.com> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F0770170D43A@SHSMSX103.ccr.corp.intel.com>


* Liang, Kan <kan.liang@intel.com> wrote:

> > * tip-bot for Kan Liang <tipbot@zytor.com> wrote:
> > 
> > > --- a/kernel/events/core.c
> > > +++ b/kernel/events/core.c
> > > @@ -4446,7 +4446,7 @@ static int perf_mmap(struct file *file, struct
> > vm_area_struct *vma)
> > >  	 * If we have rb pages ensure they're a power-of-two number, so
> > we
> > >  	 * can do bitmasks instead of modulo.
> > >  	 */
> > > -	if (!is_power_of_2(nr_pages))
> > > +	if (nr_pages != 0 && !is_power_of_2(nr_pages))
> > >  		return -EINVAL;
> > 
> > Hm, what does is_power_of_2(0) return? It should return 0, because 0 is
> > not a power of 2!
> > 
> > and if it's fixed to return 0, then the check should properly be something
> > like:
> > 
> > 	if (!nr_pages || !is_power_of_2(nr_pages))
> > 
> > or so?
> 
> nr_pages == 0 is valid, we cannot return -EINVAL. Because 
> 	vma_size = vma->vm_end - vma->vm_start;
> 	nr_pages = (vma_size / PAGE_SIZE) - 1;
> 
> So here we only want to check is_power_of_2
> when the pages > 1 (or nr_pages > 0).

I don't think you answered my first question, on which my later 
comments rely:

> > Hm, what does is_power_of_2(0) return? It should return 0, because 0 is
> > not a power of 2!

Thanks,

	Ingo

  reply	other threads:[~2015-03-04  4:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02  7:14 [PATCH 1/1] " kan.liang
2015-03-02 21:03 ` Arnaldo Carvalho de Melo
2015-03-03  6:26 ` [tip:perf/core] " tip-bot for Kan Liang
2015-03-03  8:44   ` Ingo Molnar
2015-03-03 20:04     ` Liang, Kan
2015-03-04  4:46       ` Ingo Molnar [this message]
2015-03-04 14:06         ` Liang, Kan
2015-03-04 20:28           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150304044654.GA5061@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=xiakaixu@huawei.com \
    --subject='Re: [tip:perf/core] Revert "perf: Remove the extra validity check on nr_pages"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).