LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: x86-ml <x86@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Andy Lutomirski <luto@amacapital.net>,
	lkml <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [GIT PULL] x86/alternatives padding
Date: Wed, 4 Mar 2015 12:22:06 +0100	[thread overview]
Message-ID: <20150304112206.GB3516@pd.tnic> (raw)
In-Reply-To: <20150304073221.GD22014@gmail.com>

On Wed, Mar 04, 2015 at 08:32:21AM +0100, Ingo Molnar wrote:
> Just curious: did the kernel image size change before/after these 
> changes? I.e. was any of the existing alternative instructions using 
> sites coded sub-optimally, with a larger maximum instruction size 
> allocated than strictly needed?
> 
> At least some of your improvements made things more optimal - 
> wondering at the total win, beyond the significant maintainability win 
> that is.

Well, kernel image doesn't change while vmlinux shows only a very small
.text increase of about 2K. I'm not sure yet why that happens though
because it shouldn't be the padding. Because we will have to do it
anyway, this patchset makes it automatic instead of by-hand, so to
speak.

Let me bisect it and see which patch adds the increase.

4.0-rc1 with alternatives patchset:
===================================

Setup is 15644 bytes (padded to 15872 bytes).
System is 5855 kB
CRC f2669897
Kernel: arch/x86/boot/bzImage is ready  (#1)

   text    data     bss     dec     hex filename
12292971        1595264 1085440 14973675         e47aeb vmlinux

plain 4.0-rc1:
==============

Setup is 15644 bytes (padded to 15872 bytes).
System is 5855 kB
CRC 7200607a
Kernel: arch/x86/boot/bzImage is ready  (#1)

   text    data     bss     dec     hex filename
12290539        1595264 1085440 14971243         e4716b vmlinux

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

  reply	other threads:[~2015-03-04 11:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 17:06 Borislav Petkov
2015-03-04  7:32 ` Ingo Molnar
2015-03-04 11:22   ` Borislav Petkov [this message]
2015-03-04 11:41     ` Borislav Petkov
2015-03-04 20:22       ` Ingo Molnar
2015-03-04 21:02         ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150304112206.GB3516@pd.tnic \
    --to=bp@alien8.de \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    --subject='Re: [GIT PULL] x86/alternatives padding' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).