From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759487AbbCDLnI (ORCPT ); Wed, 4 Mar 2015 06:43:08 -0500 Received: from mail.skyhub.de ([78.46.96.112]:41413 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759068AbbCDLnG (ORCPT ); Wed, 4 Mar 2015 06:43:06 -0500 Date: Wed, 4 Mar 2015 12:41:52 +0100 From: Borislav Petkov To: Ingo Molnar Cc: x86-ml , Peter Zijlstra , Arnaldo Carvalho de Melo , Andy Lutomirski , lkml , Linus Torvalds Subject: Re: [GIT PULL] x86/alternatives padding Message-ID: <20150304114151.GD3516@pd.tnic> References: <20150303170632.GE25768@pd.tnic> <20150304073221.GD22014@gmail.com> <20150304112206.GB3516@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150304112206.GB3516@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 12:22:06PM +0100, Borislav Petkov wrote: > Well, kernel image doesn't change while vmlinux shows only a very small > .text increase of about 2K. I'm not sure yet why that happens though > because it shouldn't be the padding. Because we will have to do it > anyway, this patchset makes it automatic instead of by-hand, so to > speak. > > Let me bisect it and see which patch adds the increase. Doh, of course. I've added u8 padlen to the alternative instruction entry struct. For 2Kish alt sites in total, this explains the almost exact same increase in text size: text data bss dec hex filename 12290539 1595264 1085440 14971243 e4716b vmlinux 338ea55579d1... x86/lib/copy_user_64.S: Remove FIX_ALIGNMENT define text data bss dec hex filename 12290539 1595264 1085440 14971243 e4716b vmlinux db477a3386de... x86/alternatives: Cleanup DPRINTK macro text data bss dec hex filename 12290539 1595264 1085440 14971243 e4716b vmlinux 4332195c5615... x86/alternatives: Add instruction padding text data bss dec hex filename 12293030 1595264 1085440 14973734 e47b26 vmlinux ^^^^^^^ Ok, that's sorted out now. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --